Page MenuHomePhabricator
Differential D11492

[lib] Add Coinbase Wallet support
ClosedPublic
Actions

Authored by ashoat on Mar 30 2024, 3:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:01 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
Unknown Object (File)
Mon, Dec 16, 7:44 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM1005cb0dac2a: [lib] Add Coinbase Wallet support
Summary

This addresses ENG-2985.

The patchfile change is necessary to get Rainbowkit to pass this config to Wagmi.

I discovered it when searching the GitHub issues for coinbase-wallet-sdk: here and here. I also found a Farcaster discussion about it here.

Depends on D11491

Test Plan

Testing on web running locally, and on native device via landing. Second part was tough... had to test patches on production because I couldn't get my local landing to render on my physical device

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 30 2024, 3:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 30 2024, 3:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:33 PM
Harbormaster failed remote builds in B27840: Diff 38573!
ashoat updated this revision to Diff 38578.Mar 30 2024, 3:39 PM

Rebase on D11493

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:53 PM
Harbormaster failed remote builds in B27845: Diff 38578!
ashoat updated this revision to Diff 38583.Mar 30 2024, 4:02 PM

Rebase on latest edition of D11493

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:17 PM
Harbormaster failed remote builds in B27850: Diff 38583!
ashoat updated this revision to Diff 38588.Mar 30 2024, 4:21 PM

Rebase on latest edition of D11493

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:35 PM
Harbormaster failed remote builds in B27855: Diff 38588!
ashoat updated this revision to Diff 38593.Mar 30 2024, 4:35 PM

Rebase on latest edition of D11493

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:51 PM
Harbormaster failed remote builds in B27860: Diff 38593!
ashoat updated this revision to Diff 38598.Mar 30 2024, 4:54 PM

Rebase

ashoat edited the summary of this revision. (Show Details)Mar 30 2024, 5:34 PM
ashoat updated this revision to Diff 38602.Mar 30 2024, 5:37 PM

Rebase

Harbormaster completed remote builds in B27865: Diff 38598.Mar 30 2024, 5:38 PM
Harbormaster completed remote builds in B27869: Diff 38602.Mar 30 2024, 5:58 PM
ashoat requested review of this revision.Mar 30 2024, 5:58 PM
ashoat updated this revision to Diff 38603.Mar 31 2024, 5:59 AM

Only introduce it on web. See comment here

Harbormaster completed remote builds in B27870: Diff 38603.Mar 31 2024, 6:15 AM
ginsu accepted this revision.Apr 1 2024, 9:28 AM
This revision is now accepted and ready to land.Apr 1 2024, 9:28 AM
Closed by commit rCOMM1005cb0dac2a: [lib] Add Coinbase Wallet support (authored by ashoat). · Explain WhyApr 1 2024, 10:15 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1005cb0dac2a: [lib] Add Coinbase Wallet support.

Revision Contents
Changeset List

PathSize
landing/
2 lines
lib/
utils/
24 lines
patches/
12 lines
web/
8 lines

Diff 38633

View Options

landing/siwe.react.js

Loading...
View Options

lib/utils/wagmi-utils.js

Loading...
View Options

patches/@rainbow-me+rainbowkit+2.0.4.patch

Loading...
View Options

web/app.react.js

Loading...