All of recoveryActionSourcess handled by KeyserverConnectionHandler have been unified to use the same code. This means that if invalidSessionRecovery works for two of them, it should work with all of them.
Depends on D11501
Details
Details
- Careful inspection of codepaths to confirm that these action sources are handled in the same way
- Checked changing the Flow type of actionCurrentUserInfo in invalidSessionRecovery to be a required param. Inspected new type errors to confirm that they would not occur here
- Same testing as the rest of the stack:
- Set up multi-keyserver environment following Notion doc
- Test native keyserver recovery via keyserverAuth by deleting a cookie in MariaDB console
- Hardcode incorrect userID, try same test as B, and confirm that it fails
- Test web keyserver recovery in the same way as in B
- Test incorrect userID on web in the same way as in C
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/session-utils.js | ||
|---|---|---|
| 93–112 ↗ | (On Diff #38615) | It is quite easy to introduce a bug in this long if condition. Maybe we can introduce a Set (with a descriptive name) which makes it more maintainable? |