Details
- Reviewers
ginsu - Commits
- rCOMMeedc22330e26: [keyserver][lib][web] Update SIWE package
Tested the SIWE flow end-to-end on web and confirmed it works again
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 609 ↗ | (On Diff #38786) | This change is explained here |
| 617–619 ↗ | (On Diff #38786) | It appears that in this massive PR, MALFORMED_SESSION was split into a bunch of more specific errors, which are now here. Rather than continuing to enumerate each error (there were originally only these three), I'm opting to throw the unknown_error in most cases. Clients never had code to handle malformed_session anyways |
| web/package.json | ||
| 99 ↗ | (On Diff #38786) | I removed siwe from web because it isn't used directly there at all |
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 609 ↗ | (On Diff #38791) | This change is explained here |
| 617–619 ↗ | (On Diff #38791) | It appears that in this massive PR, MALFORMED_SESSION was split into a bunch of more specific errors, which are now here. Rather than continuing to enumerate each error (there were originally only these three), I'm opting to throw the unknown_error in most cases. Clients never had code to handle malformed_session anyways |
| web/package.json | ||
| 99 ↗ | (On Diff #38791) | I removed siwe from web because it isn't used directly there at all |
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 609 ↗ | (On Diff #38811) | This change is explained here |
| 617–619 ↗ | (On Diff #38811) | It appears that in this massive PR, MALFORMED_SESSION was split into a bunch of more specific errors, which are now here. Rather than continuing to enumerate each error (there were originally only these three), I'm opting to throw the unknown_error in most cases. Clients never had code to handle malformed_session anyways |
| patches/siwe+2.1.4.patch | ||
| 1–27 ↗ | (On Diff #38811) | This was necessary because Hermes (React Native JS engine) does not support "named capture groups" in RegExp |
| web/package.json | ||
| 99 ↗ | (On Diff #38811) | I removed siwe from web because it isn't used directly there at all |