[native] Wait for authoritative keyserver login before setting avatar in registration flow
ClosedPublic
Actions

Authored by ashoat on Thu, Apr 18, 12:55 PM.

Details

Reviewers

inka
tomek
marcin

Commits

rCOMM4947ef57ce64: [native] Wait for authoritative keyserver login before setting avatar in…

Summary

When this logic was first built, currentUserInfo would appear after the authoritative keyserver auth occurred.

Now it appears after identity auth, so it's no longer the right thing to check here. Instead, we should check isLoggedInToKeyserver(authoritativeKeyserverID).

Test Plan

Make sure that I can register an account with a custom avatar, and that when the account is created the custom avatar appears

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Thu, Apr 18, 12:55 PM

ashoat mentioned this in D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.Thu, Apr 18, 12:56 PM

Harbormaster completed remote builds in B28303: Diff 39242.Thu, Apr 18, 1:19 PM

ashoat requested review of this revision.Thu, Apr 18, 1:19 PM

marcin accepted this revision.Fri, Apr 19, 2:46 AM

This revision is now accepted and ready to land.Fri, Apr 19, 2:46 AM

Closed by commit rCOMM4947ef57ce64: [native] Wait for authoritative keyserver login before setting avatar in… (authored by ashoat). · Explain WhyFri, Apr 19, 7:47 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4947ef57ce64: [native] Wait for authoritative keyserver login before setting avatar in….

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-server-call.js

10 lines

Diff 39274

View Options

native/account/registration/registration-server-call.js

[native] Wait for authoritative keyserver login before setting avatar in registration flowClosedPublicActions