Page MenuHomePhabricator

[native] Wait for authoritative keyserver login before setting avatar in registration flow
ClosedPublic

Authored by ashoat on Apr 18 2024, 12:55 PM.
Tags
None
Referenced Files
F1797640: D11693.id39274.diff
Sun, May 19, 11:24 PM
F1797639: D11693.id39242.diff
Sun, May 19, 11:24 PM
F1797627: D11693.id.diff
Sun, May 19, 11:24 PM
F1797624: D11693.diff
Sun, May 19, 11:24 PM
Unknown Object (File)
Sun, Apr 28, 7:34 PM
Unknown Object (File)
Sun, Apr 28, 7:23 PM
Unknown Object (File)
Sat, Apr 27, 12:56 PM
Unknown Object (File)
Sat, Apr 27, 11:56 AM
Subscribers
None

Details

Summary

When this logic was first built, currentUserInfo would appear after the authoritative keyserver auth occurred.

Now it appears after identity auth, so it's no longer the right thing to check here. Instead, we should check isLoggedInToKeyserver(authoritativeKeyserverID).

Test Plan

Make sure that I can register an account with a custom avatar, and that when the account is created the custom avatar appears

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable