Differential D11942

[native] Set the DB version after registration
ClosedPublic
Actions

Authored by tomek on May 8 2024, 6:59 AM.

Details

Reviewers

kamil
marcin
inka

Commits

rCOMMbe7c5a70c36c: [native] Set the DB version after registration

Summary

When a new account is created, we have to store the version in the DB so that it is included in a backup.
We don't need to set the version when a user logs in, because we can assume that eventually, we will restore the data from a backup - and that includes the version.

https://linear.app/comm/issue/ENG-7006/back-up-redux-version

Depends on D11937

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 8 2024, 6:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2024, 7:00 AM

Harbormaster completed remote builds in B28761: Diff 39931.May 8 2024, 7:16 AM

tomek requested review of this revision.May 8 2024, 7:16 AM

tomek planned changes to this revision.May 8 2024, 9:03 AM

I planned changes because I thought there was an issue with the current users - they are already registered, so we won't put the version into the DB for them and their backup won't contain it. Actually, there's no such problem, because in order to create a backup, the app should be run, and the migration from the previous diff will be performed and will put the version into the DB.

tomek added a child revision: D11947: [web] Check backup version when restoring.May 8 2024, 9:55 AM

Can you test a scenario where the migration is run on a logged out screen, and then the user logs in? Can you verify that the db has the correct version set in this case?

Can you test both SIWE and password?

This revision is now accepted and ready to land.May 14 2024, 11:15 PM

tomek removed a child revision: D11947: [web] Check backup version when restoring.May 20 2024, 3:11 AM

tomek added a child revision: D12012: [native] Create a function returning the DB version.May 20 2024, 3:14 AM

In D11942#341891, @inka wrote:

Can you test a scenario where the migration is run on a logged out screen, and then the user logs in? Can you verify that the db has the correct version set in this case?

It shouldn't matter: we aren't restoring the backup as the part of a login yet. When we start doing it, it will contain the version. Also, registration sets the version. But I checked the version in the DB - and it is correct.