Differential D11902 Authored by tomek on May 6 2024, 6:29 AM.
Details Summary All the base classes were providing the same functions. Also, it is convenient to be able to store all the ops in a single array - in order to process them in a single transaction. https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction Test Plan Opened the app, modified a draft, closed and reopened the app - the draft was correct.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptMay 6 2024, 6:29 AM2024-05-06 06:29:34 (UTC-7) Harbormaster completed remote builds in B28696: Diff 39844.May 6 2024, 6:49 AM2024-05-06 06:49:04 (UTC-7) Comment Actions I think in a couple of files you can add #include "DBOperationBase.h" to match our convention to always include header This revision is now accepted and ready to land.May 6 2024, 6:59 AM2024-05-06 06:59:32 (UTC-7) Harbormaster failed remote builds in B28790: Diff 39987!May 9 2024, 4:29 AM2024-05-09 04:29:33 (UTC-7) Harbormaster completed remote builds in B28791: Diff 39988.May 9 2024, 5:16 AM2024-05-09 05:16:06 (UTC-7) Closed by commit rCOMM4324e85e55a4: [native] Create a single base class for all the ops (authored by tomek). · Explain WhyMay 9 2024, 5:25 AM2024-05-09 05:25:21 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 39989 native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/CommunityStore.cppLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/IntegrityStore.cppLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/KeyserverStore.cppLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/SyncedMetadataStore.hLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/SyncedMetadataStore.cppLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadActivityStore.hLoading... native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadActivityStore.cppLoading... |