We don't need to use async functions that process a single store. They will be deleted in the next diff.
https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction
Depends on D11921
Differential D11922
[native] Use processDBStoreOperations function everywhere tomek on May 7 2024, 8:31 AM. Authored by Tags None Referenced Files
Subscribers
Details We don't need to use async functions that process a single store. They will be deleted in the next diff. https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction Depends on D11921 Checked if persisting drafts still works.
Diff Detail
Event TimelineComment Actions
Why only drafts? We can probably test other stores by making changes in the app, closing keyserver connection and restarting it afterwards. I would also run sth like git grep "commCoreModule.process" before and after applying this diff. Comment Actions Testing drafts is the easiest, and testing all might take too much time. Going to test e.g. messages and threads too. As for grepping, in the next diff the functions are removed which effectively verifies if all the usages were replaced. |