Page MenuHomePhabricator
Differential D12012

[native] Create a function returning the DB version
ClosedPublic
Actions

Authored by tomek on May 13 2024, 3:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 10:02 PM
Unknown Object (File)
Sat, Dec 21, 10:02 PM
Unknown Object (File)
Sat, Dec 21, 10:02 PM
Unknown Object (File)
Sat, Dec 21, 10:02 PM
Unknown Object (File)
Sat, Dec 21, 10:01 PM
Unknown Object (File)
Sat, Dec 21, 10:01 PM
Unknown Object (File)
Wed, Dec 4, 7:11 PM
Unknown Object (File)
Nov 3 2024, 10:36 AM
View All 76 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
varun
Commits
rCOMMf010d27dcad2: [native] Create a function returning the DB version
Summary

We're storing the version in synced metadata table. We don't want to fetch all the data, which means that we have to introduce a dedicated function for this.

https://linear.app/comm/issue/ENG-7008/detect-that-the-compaction-is-from-a-newer-version-than-the-app-and

Depends on D11942

Test Plan

Tested with the next diff - verified that the version returned by this function matched what was in the backup.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 13 2024, 3:26 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 13 2024, 3:26 AM
tomek added a child revision: D12013: [native] Verify if the backup version is correct.May 13 2024, 3:30 AM
Harbormaster completed remote builds in B28864: Diff 40107.May 13 2024, 3:43 AM
tomek requested review of this revision.May 13 2024, 3:43 AM
kamil accepted this revision.May 14 2024, 11:25 PM
kamil added inline comments.
native/schema/CommCoreModuleSchema.js
145 ↗(On Diff #40107)

I would prefer a more detailed name, like getSyncedDatabaseVersion but up to you

This revision is now accepted and ready to land.May 14 2024, 11:25 PM
tomek updated this revision to Diff 40226.May 15 2024, 8:02 AM

Rename

Harbormaster completed remote builds in B28942: Diff 40226.May 15 2024, 8:19 AM
tomek removed a parent revision: D11947: [web] Check backup version when restoring.May 20 2024, 3:11 AM
tomek added a parent revision: D11942: [native] Set the DB version after registration.May 20 2024, 3:14 AM
tomek edited the summary of this revision. (Show Details)Jun 3 2024, 7:07 AM
tomek updated this revision to Diff 40863.Jun 3 2024, 7:07 AM

Rebase

Harbormaster completed remote builds in B29374: Diff 40863.Jun 3 2024, 7:22 AM
Closed by commit rCOMMf010d27dcad2: [native] Create a function returning the DB version (authored by tomek). · Explain WhyJun 4 2024, 5:44 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMf010d27dcad2: [native] Create a function returning the DB version.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
34 lines
_generated/
schema/
1 line

Diff 40946

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...