Page MenuHomePhabricator

[native] Create a function returning the DB version
AcceptedPublic

Authored by tomek on Mon, May 13, 3:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 4:57 PM
Unknown Object (File)
Mon, May 13, 6:39 AM
Unknown Object (File)
Mon, May 13, 6:39 AM
Unknown Object (File)
Mon, May 13, 6:39 AM
Subscribers

Details

Reviewers
kamil
marcin
varun
Summary

We're storing the version in synced metadata table. We don't want to fetch all the data, which means that we have to introduce a dedicated function for this.

https://linear.app/comm/issue/ENG-7008/detect-that-the-compaction-is-from-a-newer-version-than-the-app-and

Depends on D11947

Test Plan

Tested with the next diff - verified that the version returned by this function matched what was in the backup.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Mon, May 13, 3:43 AM
kamil added inline comments.
native/schema/CommCoreModuleSchema.js
145 ↗(On Diff #40107)

I would prefer a more detailed name, like getSyncedDatabaseVersion but up to you

This revision is now accepted and ready to land.Tue, May 14, 11:25 PM