Page MenuHomePhabricator

[native] Create a function returning the DB version
ClosedPublic

Authored by tomek on May 13 2024, 3:26 AM.
Tags
None
Referenced Files
F3120284: D12012.diff
Fri, Nov 1, 5:24 AM
Unknown Object (File)
Thu, Oct 17, 11:24 PM
Unknown Object (File)
Thu, Oct 17, 11:23 PM
Unknown Object (File)
Thu, Oct 17, 9:46 PM
Unknown Object (File)
Sat, Oct 12, 6:19 PM
Unknown Object (File)
Sat, Oct 12, 6:19 PM
Unknown Object (File)
Sat, Oct 12, 6:19 PM
Unknown Object (File)
Sat, Oct 12, 6:19 PM
Subscribers

Details

Summary

We're storing the version in synced metadata table. We don't want to fetch all the data, which means that we have to introduce a dedicated function for this.

https://linear.app/comm/issue/ENG-7008/detect-that-the-compaction-is-from-a-newer-version-than-the-app-and

Depends on D11942

Test Plan

Tested with the next diff - verified that the version returned by this function matched what was in the backup.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.May 13 2024, 3:43 AM
kamil added inline comments.
native/schema/CommCoreModuleSchema.js
145 ↗(On Diff #40107)

I would prefer a more detailed name, like getSyncedDatabaseVersion but up to you

This revision is now accepted and ready to land.May 14 2024, 11:25 PM