[lib][web][native] Make all the props of StoreOperations optional
ClosedPublic
Actions

Authored by tomek on Wed, May 8, 4:24 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMMe3f2aff62c8f: [lib][web][native] Make all the props of StoreOperations optional

Summary

Before this diff we had to create objects with all the fields present even when most of them were empty arrays. This diff makes creating the ops object more convenient.

Depends on D11933

Test Plan

Tested if processing the ops still works on web and native by checking if drafts get persisted.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Wed, May 8, 4:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptWed, May 8, 4:24 AM

Harbormaster completed remote builds in B28755: Diff 39925.Wed, May 8, 4:41 AM

tomek requested review of this revision.Wed, May 8, 4:41 AM

tomek added a child revision: D11937: [lib] Update DB version while running a migration.Wed, May 8, 5:13 AM

Wondering if updating convertOpsToClientDBOps to handle nullable param wouldn't be even more readable but up to you

This revision is now accepted and ready to land.Fri, May 10, 6:15 AM

In D11936#342562, @kamil wrote:

Wondering if updating convertOpsToClientDBOps to handle nullable param wouldn't be even more readable but up to you

Good idea - I'll check it.

Modify convertOpsToClientDBOps

Harbormaster completed remote builds in B28892: Diff 40151.Tue, May 14, 4:46 AM

Closed by commit rCOMMe3f2aff62c8f: [lib][web][native] Make all the props of StoreOperations optional (authored by tomek). · Explain WhyTue, May 14, 4:49 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe3f2aff62c8f: [lib][web][native] Make all the props of StoreOperations optional.