Page MenuHomePhabricator
Differential D11702

Remove unecessary SQLite initialization from CommHybrid
ClosedPublic
Actions

Authored by marcin on Fri, Apr 19, 9:48 AM.
Tags
None
Referenced Files
F1779897: D11702.diff
Sat, May 18, 1:53 AM
Unknown Object (File)
Thu, May 2, 6:58 PM
Unknown Object (File)
Wed, May 1, 9:43 PM
Unknown Object (File)
Fri, Apr 26, 8:47 PM
Unknown Object (File)
Fri, Apr 26, 5:15 PM
Unknown Object (File)
Thu, Apr 25, 5:24 PM
Unknown Object (File)
Wed, Apr 24, 9:08 AM
Unknown Object (File)
Tue, Apr 23, 11:25 PM
View All 15 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
tomek
Commits
rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid
Summary

This differential removes unnecessary and potentially buggy SQLite initialization from CommHybrid. The context is here:
https://linear.app/comm/issue/ENG-7700/reconsider-double-sqlitequeryexecutorinitialize-calls-on-android

Test Plan

Uninstall and reinstall Android app a couple of times. Ensure each time app works correctly.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-7700
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Fri, Apr 19, 9:48 AM
marcin added 1 blocking reviewer(s): kamil.Fri, Apr 19, 9:49 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Apr 19, 9:58 AM
Harbormaster failed remote builds in B28331: Diff 39290!
Harbormaster completed remote builds in B28331: Diff 39290.Fri, Apr 19, 10:08 AM
marcin requested review of this revision.Fri, Apr 19, 10:08 AM
ashoat accepted this revision.Fri, Apr 19, 12:02 PM

Nice to clean up the additionalParameters stuff

kamil accepted this revision.Mon, Apr 22, 3:40 AM
This revision is now accepted and ready to land.Mon, Apr 22, 3:40 AM
marcin updated this revision to Diff 39337.Mon, Apr 22, 5:09 AM

Rebase before landing

Harbormaster completed remote builds in B28353: Diff 39337.Mon, Apr 22, 5:24 AM
Closed by commit rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid (authored by marcin). · Explain WhyMon, Apr 22, 5:33 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
12 lines
main/
java/
app/
comm/
android/
fbjni/
12 lines

Diff 39337

View Options

native/android/app/src/cpp/jsiInstaller.cpp

Loading...
View Options

native/android/app/src/main/java/app/comm/android/fbjni/CommHybrid.java

Loading...