Page MenuHomePhabricator
Differential D11712

[lib] Shim unsupported messages for `web`/`desktop`
ClosedPublic
Actions

Authored by atul on Mon, Apr 22, 10:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 5:01 AM
Unknown Object (File)
Wed, May 1, 4:44 PM
F1689509: 870d7f.png
Wed, May 1, 4:30 PM
F1689507: c27e4f.png
Wed, May 1, 4:30 PM
Unknown Object (File)
Mon, Apr 29, 7:05 AM
Unknown Object (File)
Sun, Apr 28, 6:01 PM
Unknown Object (File)
Fri, Apr 26, 12:51 PM
Unknown Object (File)
Mon, Apr 22, 5:21 PM
View All 10 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM4c5a86dbda62: [lib] Shim unsupported messages for `web`/`desktop`
Summary

We currently aren't shimming messages for web/desktop, probably because we weren't previously persisting things on those platforms?

However, now that we are persisting messages we'll want to shim/unshim messages. Specically we want to shim/unshim the new UPDATE_RELATIONSHIP message type.

Test Plan
WARNING: I'm still reading through codebase to make sure that this change is safe and can be made as-is. I also haven't yet tested this function with UPDATE_RELATIONSHIP messages to make sure it behaves as expected. Just putting this up to reference in comment on D11707

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mon, Apr 22, 10:13 AM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Apr 22, 10:13 AM
atul mentioned this in D11707: [keyserver] Send farcaster_mutual UPDATE_RELATIONSHIP message when establishing Farcaster relationship.Mon, Apr 22, 10:16 AM
Harbormaster completed remote builds in B28355: Diff 39344.Mon, Apr 22, 10:31 AM
atul requested review of this revision.Mon, Apr 22, 10:31 AM
ashoat accepted this revision.Mon, Apr 22, 11:01 AM
This revision is now accepted and ready to land.Mon, Apr 22, 11:01 AM
ashoat added a child revision: D11707: [keyserver] Send farcaster_mutual UPDATE_RELATIONSHIP message when establishing Farcaster relationship.Fri, Apr 26, 5:41 PM
atul added a comment.Wed, May 1, 4:30 PM

Did testing to ensure UNSUPPORTED messages appear as expected on web client:

  1. Rewrote the request in updateRelationships so that I could avoid making client changes:

c27e4f.png (740×1 px, 112 KB)

  1. Ensured that UNSUPPORTED message appeared in web Redux store:

870d7f.png (304×972 px, 51 KB)

atul updated this revision to Diff 39723.Wed, May 1, 4:35 PM

rebase and land

Harbormaster completed remote builds in B28617: Diff 39723.Wed, May 1, 4:52 PM
Closed by commit rCOMM4c5a86dbda62: [lib] Shim unsupported messages for `web`/`desktop` (authored by atul). · Explain WhyWed, May 1, 4:54 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4c5a86dbda62: [lib] Shim unsupported messages for `web`/`desktop`.

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 39724

View Options

lib/shared/message-utils.js

Loading...