Page MenuHomePhabricator
Differential D11744

[identity] add env var conditional json tracing
ClosedPublic
Actions

Authored by will on Tue, Apr 23, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 2:43 PM
Unknown Object (File)
Wed, May 1, 6:09 PM
Unknown Object (File)
Wed, May 1, 1:27 PM
Unknown Object (File)
Wed, May 1, 11:39 AM
Unknown Object (File)
Wed, May 1, 10:41 AM
Unknown Object (File)
Tue, Apr 30, 5:40 PM
Unknown Object (File)
Tue, Apr 30, 1:15 PM
Unknown Object (File)
Tue, Apr 30, 9:26 AM
View All 15 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing
Summary

Initializes environment with json tracing if the COMM_SERVICES_USE_JSON_LOGS environmental variable is set to "true"

Test Plan

cargo check. Runs with json logs when I set env var to "true" and regular logs when "false".

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Tue, Apr 23, 11:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 23, 11:40 AM
Harbormaster completed remote builds in B28416: Diff 39421.Tue, Apr 23, 12:01 PM
will requested review of this revision.Tue, Apr 23, 12:01 PM
bartek accepted this revision.Wed, Apr 24, 2:19 AM

As a follow-up, we probably want to extract this logic to comm-lib because finally I'd love to see all services using JSON logs in AWS

This revision is now accepted and ready to land.Wed, Apr 24, 2:19 AM
will updated this revision to Diff 39525.Thu, Apr 25, 9:18 PM

rebase

will updated this revision to Diff 39526.Thu, Apr 25, 9:25 PM

rebase

This revision was landed with ongoing or failed builds.Thu, Apr 25, 9:28 PM
Closed by commit rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing.
Harbormaster completed remote builds in B28493: Diff 39525.Thu, Apr 25, 9:37 PM
Harbormaster completed remote builds in B28494: Diff 39526.Thu, Apr 25, 9:40 PM

Revision Contents
Changeset List

PathSize
services/
identity/
2 lines
src/
4 lines
20 lines

Diff 39527

View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/main.rs

Loading...