Plan to be using this button in subsquent diffs. I figured since this button is used more generally than just for the registration we should rename this to be SubmitButton
Depends on D11855
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
- I don't think SubmitButton is a great name for this. It's used for actions other than submitting.
- I don't think it makes sense to move this component out by itself. It's tightly coupled to the other visual components in the native/account/registration folder, and now it's pretty weird that some of them are in that folder and some are elsewhere.
Some time ago Atul created a task to track moving some of the general-purpose visual components in native/account/registration elsewhere: ENG-3929. There I suggested using the name prefix Panel, eg. PanelButton.
We already have a PanelButton and a Panel, but we could rename those first, eg. to LegacyPanelButton or LoginPanelButton.
Some concrete suggestions:
- Rename existing PanelButton, Panel, etc.
- Go with PanelButton for this component
- Create a separate folder for it inside native/components (eg. native/components/panel)
- Move and rename the other related visual components too
Comment Actions
Removing this diff from the diff stack and will address the feedback for this in a separate diff stack