Page MenuHomePhabricator
Differential D11855

[native] introduce navigational logic for TagUnfollowedFarcasterChannel screen
ClosedPublic
Actions

Authored by ginsu on Wed, May 1, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 6:41 PM
Unknown Object (File)
Sun, May 12, 5:19 PM
Unknown Object (File)
Sun, May 12, 6:51 AM
Unknown Object (File)
Fri, May 10, 1:00 PM
Unknown Object (File)
Fri, May 10, 8:59 AM
Unknown Object (File)
Wed, May 8, 4:15 PM
Unknown Object (File)
Mon, May 6, 6:24 PM
Unknown Object (File)
Mon, May 6, 11:05 AM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMM303ee4ec2331: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen
Summary

One of our user experiences for tagging a farcaster channel to a community is that we want to allow the user to amnually type the farcaster channel name into a text field to tag the channel if they can't find the channel in the dropdown. This diff introduces all the navigational + boilerplate screen we will need to introduce this user experience

Test Plan

flow + confirmed I was able to navigate to the boilerplate screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, May 1, 10:58 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, May 1, 10:58 PM
ginsu added a reviewer: inka.Wed, May 1, 11:05 PM
ginsu added a reviewer: ashoat.

This diff has copy changes that need to be reviewed

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js
55 ↗(On Diff #39737)

Thought it would make sense to have the header title be the same for both screens, but open to changing it. Regardless this copy should be reviewed

ginsu added a child revision: D11856: [native] refactor registration button to be submit button.Wed, May 1, 11:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 1, 11:12 PM
Harbormaster failed remote builds in B28626: Diff 39737!
ginsu requested review of this revision.Fri, May 3, 12:22 AM

will make sure ci passes before landing

Harbormaster completed remote builds in B28626: Diff 39737.Fri, May 3, 11:21 AM
ashoat accepted this revision.Sat, May 4, 10:51 AM
ashoat added inline comments.
native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js
55 ↗(On Diff #39737)

Makes sense to me

native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
18 ↗(On Diff #39737)

“Unfollowed” seems weird to me since it seems to imply that it was first followed and then unfollowed

I thought about TagNotFollowedFarcasterChannel and TagCustomFarcasterChannel, but I think I like TagFarcasterChannelByName the best. What do you think?

This revision is now accepted and ready to land.Sat, May 4, 10:51 AM
ginsu added inline comments.Sun, May 5, 5:05 PM
native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
18 ↗(On Diff #39737)

TagFarcasterChannelByName makes sense to me

ginsu updated this revision to Diff 39802.Sun, May 5, 5:06 PM

address comments

This revision was landed with ongoing or failed builds.Sun, May 5, 5:10 PM
Closed by commit rCOMM303ee4ec2331: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM303ee4ec2331: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
Harbormaster completed remote builds in B28675: Diff 39802.Sun, May 5, 5:22 PM
ginsu added a child revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.Sun, May 5, 5:28 PM
ginsu removed a child revision: D11856: [native] refactor registration button to be submit button.
ginsu removed a child revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.Sun, May 5, 5:46 PM
ginsu added a child revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.Mon, May 6, 7:24 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
22 lines
12 lines
navigation/
3 lines

Diff 39803

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...