Page MenuHomePhabricator

[native] Fetch invite links when entering thread settings
ClosedPublic

Authored by inka on Mon, Jun 3, 8:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 11:31 AM
Unknown Object (File)
Thu, Jun 20, 11:54 PM
Unknown Object (File)
Thu, Jun 20, 5:39 PM
Unknown Object (File)
Thu, Jun 20, 6:55 AM
Unknown Object (File)
Wed, Jun 19, 5:34 AM
Unknown Object (File)
Mon, Jun 17, 5:26 AM
Unknown Object (File)
Tue, Jun 11, 3:28 PM
Unknown Object (File)
Tue, Jun 11, 10:19 AM
Subscribers

Details

Summary

part of ENG-7793
while testing I noticed that sometimes when I enter thread settings, a thread that does have an invite link appears to not have it. This is because we used to only fetch invite links when opening the community drawer, because this was the only place we were displaying them. Now I am also displaying them in thread settings, and the user may navigate to them without ever opening the drawer.
This is not the best solution, but this is a compromise we decided on when implementing invite links to avoid implementing updates for them

Test Plan

Tested that now when the user opens the app and navigates to thread settings immediately, the invite link is fetched

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Mon, Jun 3, 9:20 AM
tomek added inline comments.
native/chat/settings/thread-settings.react.js
1339–1349 ↗(On Diff #40884)

Maybe add a code comment explaining this.

This revision is now accepted and ready to land.Tue, Jun 4, 1:10 AM