We need to include the communityStore in the initialReduxState as part of the work to introducing the communities table in the keyserver
Depends on D12043
Paths
| Differential D12060 Authored by ginsu on May 15 2024, 6:13 PM.
Details Summary We need to include the communityStore in the initialReduxState as part of the work to introducing the communities table in the keyserver Depends on D12043 Test Plan Confirmed that the community store with the correct community infos was a part of the SET_INITIAL_REDUX_STATE action payload
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptMay 15 2024, 6:13 PM2024-05-15 18:13:42 (UTC-7) ginsu edited the test plan for this revision. (Show Details)May 15 2024, 6:18 PM2024-05-15 18:18:44 (UTC-7) ginsu added inline comments.
Harbormaster completed remote builds in B28965: Diff 40262.May 15 2024, 6:30 PM2024-05-15 18:30:10 (UTC-7)
ginsu edited the summary of this revision. (Show Details)May 15 2024, 7:11 PM2024-05-15 19:11:28 (UTC-7) Comment Actions One question: If my suspicion is correct this diff is not needed but I wasn't reviewing the rest of the stack and I am missing some context so sorry for confusing if this was taken into account and this is still needed. Comment Actions
With the refresher approach we don't need to persist this data at all - opening the drawer / focusing web app would result in new data being sent from the keyserver. If we don't trust our persistence, we can keep this diff and persist its result on clients - this would mean that we never use the persisted state on the web. Later we can update the approach. In the final approach, we would need the clients to send an additional parameter telling if the server should include communityStore in the initial state. An alternative might be to abandon this diff and avoid sending the store in the initial state. Requesting changes because we need to make a decision here. This revision now requires changes to proceed.May 28 2024, 4:47 AM2024-05-28 04:47:33 (UTC-7) Comment Actions
This makes sense and since we only use this info when we open the community drawer on native and when we focus the app on web, abandoning this diff is probably the best approach for now so that we can keep the scope limited.
Revision Contents
Diff 40262 keyserver/src/fetchers/community-fetchers.js
keyserver/src/responders/redux-state-responders.js
lib/types/community-types.js
lib/types/redux-types.js
|