We need to include the communityStore in the initialReduxState as part of the work to introducing the communities table in the keyserver
Depends on D12043
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/fetchers/community-fetchers.js | ||
|---|---|---|
| 16 | As I was testing, noticed this issue, and snuck a fix here | |
| keyserver/src/fetchers/community-fetchers.js | ||
|---|---|---|
| 16 | I don't see a stack attached to this diff, but I also don't see this file on master. Can you attach a stack, and add this fix to the diff that made the initial error? | |
Comment Actions
One question:
If I remember correctly CommunityStore was introduced directly for SQLite which means web clients should have it - so there is no need to fetch and return it again as this is a duplication of data client should have.
If communityStore changed in keyserver DB we should have some mechanism (updates/state sync/handler which fetches it) to get the newest data.
If my suspicion is correct this diff is not needed but I wasn't reviewing the rest of the stack and I am missing some context so sorry for confusing if this was taken into account and this is still needed.
Comment Actions
With the refresher approach we don't need to persist this data at all - opening the drawer / focusing web app would result in new data being sent from the keyserver.
If we don't trust our persistence, we can keep this diff and persist its result on clients - this would mean that we never use the persisted state on the web. Later we can update the approach.
In the final approach, we would need the clients to send an additional parameter telling if the server should include communityStore in the initial state. An alternative might be to abandon this diff and avoid sending the store in the initial state.
Requesting changes because we need to make a decision here.
Comment Actions
An alternative might be to abandon this diff and avoid sending the store in the initial state.
This makes sense and since we only use this info when we open the community drawer on native and when we focus the app on web, abandoning this diff is probably the best approach for now so that we can keep the scope limited.