Page MenuHomePhabricator
Differential D11893

[native] improve error handling for TagUnfollowedFarcasterChannel screen
ClosedPublic
Actions

Authored by ginsu on May 6 2024, 12:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 1:44 PM
Unknown Object (File)
Wed, Apr 16, 5:53 AM
Unknown Object (File)
Wed, Apr 16, 12:55 AM
Unknown Object (File)
Wed, Apr 16, 12:33 AM
Unknown Object (File)
Tue, Apr 15, 11:04 PM
Unknown Object (File)
Tue, Apr 15, 9:18 AM
Unknown Object (File)
Sat, Apr 12, 4:13 PM
Unknown Object (File)
Thu, Apr 10, 4:36 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMM7c234d76cde5: [native] improve error handling for TagUnfollowedFarcasterChannel screen
Summary

This diff improves the error handling for TagUnfollowedFarcasterChannel by providing a few error messages to the user based on the error.message that was given

Depends on D11866

Test Plan

Please see the screenshots below

Screenshot 2024-05-06 at 3.06.48 AM.png (1×1 px, 706 KB)

Screenshot 2024-05-06 at 3.07.18 AM.png (1×1 px, 703 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 6 2024, 12:09 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 6 2024, 12:09 AM
ginsu edited the summary of this revision. (Show Details)May 6 2024, 12:10 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, ashoat.
ginsu added a parent revision: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.
ginsu attached a referenced file: F1706982: Screenshot 2024-05-06 at 3.07.18 AM.png. (Show Details)
ginsu attached a referenced file: F1706983: Screenshot 2024-05-06 at 3.06.48 AM.png. (Show Details)
ginsu added inline comments.May 6 2024, 12:17 AM
native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js
21 ↗(On Diff #39827)

This copy was approved in D11809

22 ↗(On Diff #39827)

This copy needs to be reviewed

ginsu added a child revision: D11894: [native] introduce tag channel by name option in action sheet.May 6 2024, 12:22 AM
Harbormaster completed remote builds in B28683: Diff 39827.May 6 2024, 12:26 AM
ginsu requested review of this revision.May 6 2024, 12:26 AM
inka added a comment.May 6 2024, 1:33 AM

padding around error message looks different than in invite links, can we make it more consistent?

image.png (402×710 px, 56 KB)

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js
21 ↗(On Diff #39827)

Can we avoid copy-pasting and have this defined in one place?

ginsu updated this revision to Diff 39865.May 6 2024, 10:34 AM

address comments

ginsu added inline comments.May 6 2024, 10:35 AM
native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js
5 ↗(On Diff #39865)

This copy needs to be reviewed

ginsu added a comment.May 6 2024, 10:38 AM

padding around error message looks different than in invite links, can we make it more consistent?

Updated the padding to match the screens of invite links which had 8px of padding above and below the error message

Screenshot 2024-05-06 at 1.36.52 PM.png (1×948 px, 523 KB)

ginsu attached a referenced file: F1709518: Screenshot 2024-05-06 at 1.36.52 PM.png. (Show Details)May 6 2024, 10:38 AM
Harbormaster completed remote builds in B28713: Diff 39865.May 6 2024, 10:51 AM
ashoat resigned from this revision.May 6 2024, 12:11 PM

Just one comment on the copy

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js
5 ↗(On Diff #39865)

Let's go with "Could not" instead of "Cannot"

inka accepted this revision.May 7 2024, 5:11 AM
This revision is now accepted and ready to land.May 7 2024, 5:11 AM
ginsu updated this revision to Diff 39898.May 7 2024, 10:15 AM

address comments

This revision was landed with ongoing or failed builds.May 7 2024, 10:17 AM
Closed by commit rCOMM7c234d76cde5: [native] improve error handling for TagUnfollowedFarcasterChannel screen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7c234d76cde5: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
Harbormaster completed remote builds in B28740: Diff 39898.May 7 2024, 10:32 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
41 lines
8 lines
7 lines

Diff 39899

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines