Page MenuHomePhabricator

[lib] introduce updateThreadStoreThreadInfos
ClosedPublic

Authored by ginsu on Wed, Jun 12, 3:11 AM.
Tags
None
Referenced Files
F2106561: D12400.id41230.diff
Tue, Jun 25, 8:16 AM
Unknown Object (File)
Mon, Jun 24, 3:00 PM
Unknown Object (File)
Sun, Jun 23, 3:26 AM
Unknown Object (File)
Wed, Jun 19, 11:44 AM
Unknown Object (File)
Mon, Jun 17, 10:30 PM
Unknown Object (File)
Mon, Jun 17, 10:30 PM
Unknown Object (File)
Mon, Jun 17, 10:30 PM
Unknown Object (File)
Mon, Jun 17, 10:29 PM
Subscribers

Details

Summary

This is the util function that will be called in both web and native persist.js files to update thread infos in the thread store using the new migration approach.

To implement this method I used the preexisting createUpdateDBOpsForThreadStoreThreadInfos util function as inspiration.

Test Plan

Tested further in the stack and will flesh out test plan there, but at the end of the stack tested new clients, old clients, and the state sync mechanism and everything worked as expected

As I was testing, I logged out the value of stateCheckStatus in handleResponsesClientSocketMessage and kept getting the following log:

stateCheckStatus { status: 'state_validated' }

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: tomek, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Wed, Jun 12, 3:27 AM
This revision is now accepted and ready to land.Wed, Jun 12, 4:13 AM