[keyserver/lib] update deleteFarcasterChannelTag to use communites table
AcceptedPublic
Actions

Authored by ginsu on Thu, May 9, 11:00 AM.

Details

Reviewers

tomek
kamil

Summary

Now that we have a communities table that was introduced in D11903, we can use it to better improve our deleteFarcasterChannelTag method

Depends on D11975

Test Plan

Removed the farcaster channel tag and confirmed that the farcaster channel id and the blob holder were removed in the correct row of the communites table + also confirmed that the blob holding the farcaster channel <> comm community association was deleted

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Thu, May 9, 11:00 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, May 9, 11:00 AM

ginsu edited the summary of this revision. (Show Details)Thu, May 9, 11:02 AM

ginsu added reviewers: tomek, kamil.

ginsu added a parent revision: D11975: [keyserver/lib] upate createOrUpdateFarcasterChannelTag to use communites table.

ginsu added inline comments.Thu, May 9, 11:07 AM

keyserver/src/deleters/farcaster-channel-tag-deleters.js
29–34	Initially tried to use `RETURNING blob_holder AS blobHolder` as part of the query (just like in `deleteInviteLink`); however, was getting a `You have an error in your SQL syntax;` error so created a separate query to get the blob holder and now everything works as expected
lib/types/community-types.js
31	Initially we were passing the blobHolder as part of the request since the blob holder was temporarily stored in redux; however, now that we can store the blobHolder in the communities table on the keyserver, the blob holder should never be in the client so we should remove it as part of the request

Harbormaster completed remote builds in B28816: Diff 40030.Thu, May 9, 11:16 AM

ginsu requested review of this revision.Thu, May 9, 11:16 AM

tomek accepted this revision.Fri, May 10, 4:15 AM

tomek added inline comments.

keyserver/src/deleters/farcaster-channel-tag-deleters.js
29–34	It seems like MariaDB doesn't support `RETURNING` with `UPDATE` statements https://mariadb.com/kb/en/update/. I can see some problems with the current implementation: Is it guaranteed that the select will happen before the update? Are we sure that the rows can't be modified before select and update? There are at least 3 possible solutions: We can consider using https://mariadb.com/kb/en/replace/ Maybe transactions can help with this Maybe it is possible to delete and insert instead of update The chance for this edge case is really low, so we should decide if we really care about it.