Page MenuHomePhabricator
Differential D12352

[lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes
AcceptedPublic
Actions

Authored by inka on Fri, Jun 7, 8:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 2:00 PM
Unknown Object (File)
Fri, Jun 21, 9:24 AM
Unknown Object (File)
Fri, Jun 21, 6:43 AM
Unknown Object (File)
Fri, Jun 21, 6:42 AM
Unknown Object (File)
Wed, Jun 19, 7:41 PM
Unknown Object (File)
Sun, Jun 16, 10:44 PM
Unknown Object (File)
Sun, Jun 16, 10:14 PM
Unknown Object (File)
Fri, Jun 14, 8:38 PM
View All 14 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Summary

issue: ENG-8365
We want the username to be fetched from identity. This is handled by UserInfosHandler, which checks if there are any user infos with null username

Test Plan

Joined a community, checked that user infos for new users had a null id, and for user the user already knew the username was unchanged.
Checked that after a while the usernames were fetched from identity

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Fri, Jun 7, 8:39 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Jun 7, 8:39 AM
inka added a parent revision: D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.Fri, Jun 7, 8:44 AM
Harbormaster completed remote builds in B29533: Diff 41109.Fri, Jun 7, 8:56 AM
inka requested review of this revision.Fri, Jun 7, 8:56 AM
ashoat added inline comments.Sun, Jun 9, 6:45 AM
lib/reducers/user-reducer.js
204–220 ↗(On Diff #41109)

Does Flow not like this?

tomek accepted this revision.Mon, Jun 10, 3:15 AM
This revision is now accepted and ready to land.Mon, Jun 10, 3:15 AM
inka updated this revision to Diff 41547.Thu, Jun 20, 2:41 AM

Address review

Harbormaster failed remote builds in B29814: Diff 41547!Thu, Jun 20, 2:45 AM
inka edited parent revisions, added: D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes; removed: D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.Thu, Jun 20, 3:01 AM
Harbormaster completed remote builds in B29814: Diff 41547.Thu, Jun 20, 3:13 AM
inka added a child revision: D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.Thu, Jun 20, 4:35 AM
inka planned changes to this revision.Thu, Jun 20, 6:55 AM

I should exclude commbot, because it doesn't exist on the staging identity....

inka updated this revision to Diff 41595.Fri, Jun 21, 12:08 AM

Don't remove commbot username. I didn't do it for all bots, because Object.entries(bots) is mixed, so there is no easy way to get the id. Also commbot is our only bot, so I don't think this is worth spending time on now

This revision is now accepted and ready to land.Fri, Jun 21, 12:08 AM
Harbormaster completed remote builds in B29860: Diff 41595.Fri, Jun 21, 12:28 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
35 lines

Diff 41595

View Options

lib/reducers/user-reducer.js

Loading...