Differential D12042

[native] extend loading logic to include fetching farcaster channel info
AbandonedPublic
Actions

Authored by ginsu on May 15 2024, 1:25 AM.

Details

Reviewers

tomek
inka

Summary

Right now the Tag channel button will show a loading indicator when the create or update farcaster channel tag action is running. However, in the previous diff (D12041) I introduced a mechanism to fetch the farcaster channel info. While we are fetching the farcaster channel info, we should continue showing the loading spinner

Depends on D12041

Test Plan

Please see demo video

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 15 2024, 1:25 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 15 2024, 1:25 AM

ginsu edited the summary of this revision. (Show Details)May 15 2024, 1:28 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: tomek, inka.

ginsu added a parent revision: D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.

ginsu attached a referenced file: F1766037: Screen Recording 2024-05-15 at 4.27.02 AM.mov. (Show Details)

ginsu added a child revision: D12043: [native] introduce RemoveTagButton.May 15 2024, 1:32 AM

Harbormaster completed remote builds in B28928: Diff 40202.May 15 2024, 1:42 AM

ginsu requested review of this revision.May 15 2024, 1:42 AM

inka accepted this revision.May 15 2024, 2:42 AM

This revision is now accepted and ready to land.May 15 2024, 2:42 AM

We got rid of the mechanism to fetch the farcaster channel info since we are using the /CHANNEL_ID over the channel name, so this diff is no longer relevant