[keyserver] modify thread creator + deleter endpoints to update communities table
AcceptedPublic
Actions

Authored by ginsu on Mon, May 6, 6:56 AM.

Details

Reviewers

tomek
kamil

Summary

With our new communities table on the keyserver we want to make sure that if a root level thread is created or deleted (a communitiy) that we also create + delete the respective row in the communities table.

Depends on D11903

Test Plan

Created a thread through the community creation user flow + confirmed that a new row was inserted in both the threads and communities tables. Deleted that root thread (communitiy) and confirmed that the correct row was removed in both the threads table and the communities table

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mon, May 6, 6:56 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, May 6, 6:56 AM

Harbormaster completed remote builds in B28699: Diff 39847.Mon, May 6, 7:12 AM

ginsu requested review of this revision.Mon, May 6, 7:12 AM

ginsu added reviewers: tomek, kamil.Mon, May 6, 9:14 AM

ashoat added inline comments.Mon, May 6, 12:04 PM

keyserver/src/creators/thread-creator.js
490 ↗	(On Diff #39847)	Nit: what's this space for?
491 ↗	(On Diff #39847)	Do we really need to wait on `createMessages` etc. to complete before running this? Can we run it in parallel instead?

tomek requested changes to this revision.Tue, May 7, 2:23 AM

tomek added inline comments.

keyserver/src/creators/thread-creator.js
486–489 ↗	(On Diff #39847)	Can we make this insert happen in the same statement / transaction as the insert to `threads` table? What would happen if an exception is thrown after we insert into `threads` but before we insert into `communities`?
keyserver/src/deleters/thread-deleters.js
98 ↗	(On Diff #39847)	Should we also clean this table in `cron.js`?

This revision now requires changes to proceed.Tue, May 7, 2:23 AM

ginsu edited the summary of this revision. (Show Details)Tue, May 7, 10:20 AM

ginsu added a parent revision: D11903: [keyserver] introduce a table for communities.

ashoat added inline comments.Tue, May 7, 6:24 PM

keyserver/src/deleters/thread-deleters.js
98 ↗	(On Diff #39847)	This function is called by `deleteInaccessibleThreads` below, which is called from `cron.js`

address comments

ginsu added inline comments.Wed, May 8, 11:38 PM

keyserver/src/creators/thread-creator.js
344	The newline is just my personal preference + I always find it easier to read w/ more space. Happy to remove if others feel strongly otherwise
keyserver/src/deleters/thread-deleters.js
98	As mentioned by @ashoat earlier: This function is called by deleteInaccessibleThreads below, which is called from cron.js