Paths

Table of Contentst

Differential D12329

[lib] Dispatch processNewUserIDsActionType
ClosedPublic
Actions

Authored by inka on Jun 6 2024, 3:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 8:22 PM

	Unknown Object (File)
	Sat, Dec 7, 3:32 AM

	Unknown Object (File)
	Nov 16 2024, 6:14 AM

	Unknown Object (File)
	Nov 11 2024, 6:11 AM

	Unknown Object (File)
	Nov 11 2024, 6:02 AM

	Unknown Object (File)
	Nov 11 2024, 4:46 AM

	Unknown Object (File)
	Nov 11 2024, 2:16 AM

	Unknown Object (File)
	Nov 11 2024, 1:28 AM

View All 73 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMa5cc4bae8fe7: [lib] Dispatch processNewUserIDsActionType

Summary

issue: [[https://linear.app/comm/issue/ENG-8190/[inka][june]-userstore-syncing-stop-processing-data-from-secondary | ENG-8190]]
After extracting user ids from server message we want to dispatch processNewUserIDsActionType to create entries for these ids in the user store. Then, UserInfosHandler will fetch missing user infos.

Test Plan

Tested that the action is dispatched both for socket messages and http api responses

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 6 2024, 3:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2024, 3:49 AM

inka added a parent revision: D12328: [lib] Avoid unnecessary state change in user reducer.Jun 6 2024, 3:49 AM

Harbormaster completed remote builds in B29482: Diff 41035.Jun 6 2024, 4:05 AM

inka requested review of this revision.Jun 6 2024, 4:05 AM

tomek accepted this revision.Jun 6 2024, 4:18 AM

tomek added inline comments.

lib/socket/user-infos-handler.react.js
14–35 ↗	(On Diff #41035)	Up to you, but we can `useDispatch()` here instead of passing the value as a prop

This revision is now accepted and ready to land.Jun 6 2024, 4:18 AM

inka added a child revision: D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.Jun 6 2024, 4:22 AM

Actually I should avoid dispatching the action if userIDs is empty. This results in a lot of unnecessary actions, mostly from PONG message

Stop dispatching if array empty

This revision is now accepted and ready to land.Jun 6 2024, 5:08 AM

Harbormaster completed remote builds in B29486: Diff 41039.Jun 6 2024, 5:24 AM

ashoat added inline comments.Jun 6 2024, 10:34 AM

lib/socket/user-infos-handler.react.js
14–35 ↗	(On Diff #41035)	Personally I think this would be cleaner

Move dispatch

Harbormaster completed remote builds in B29530: Diff 41106.Jun 7 2024, 7:39 AM

Closed by commit rCOMMa5cc4bae8fe7: [lib] Dispatch processNewUserIDsActionType (authored by inka). · Explain WhyJun 25 2024, 1:21 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa5cc4bae8fe7: [lib] Dispatch processNewUserIDsActionType.

Revision Contents
Changeset List

Path

Size

lib/

keyserver-conn/

call-single-keyserver-endpoint.js

2 lines

socket/

user-infos-handler.react.js

26 lines

utils/

user-info-extraction-utils.js

11 lines

Diff 41683

lib/keyserver-conn/call-single-keyserver-endpoint.js

Loading...

lib/socket/user-infos-handler.react.js

Loading...

lib/utils/user-info-extraction-utils.js

Loading...