Paths

Table of Contentst

Differential D12318

[lib] Don't remove avatar when fetching username
ClosedPublic
Actions

Authored by inka on Wed, Jun 5, 6:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 5:59 AM

	Unknown Object (File)
	Fri, Jun 21, 5:36 AM

	Unknown Object (File)
	Wed, Jun 19, 8:11 AM

	Unknown Object (File)
	Sun, Jun 16, 3:41 AM

	Unknown Object (File)
	Fri, Jun 14, 11:02 AM

	Unknown Object (File)
	Wed, Jun 12, 1:58 PM

	Unknown Object (File)
	Wed, Jun 12, 11:27 AM

	Unknown Object (File)
	Wed, Jun 12, 6:48 AM

View All 19 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username

Summary

When findUserIdentitiesActionTypes.success is dispatched, an entry for this id may already exist in the store - we may have gotten the user infos from auth keyserver already. We don't want to forget other values of this user info. Namely - avatar and relationshipStatus.

Test Plan

Dispatched findUserIdentitiesActionTypes.success without avatar for an entry that existed in the store and had an avatar. Checked that the updated entry still had the avatar.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Wed, Jun 5, 6:09 AM

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Jun 5, 6:09 AM

inka added a parent revision: D12313: [keyserver][lib] Add ACKNOWLEDGE relationship action.Wed, Jun 5, 6:09 AM

inka added a child revision: D12319: [lib] Fetch user avatars for new user ids.Wed, Jun 5, 6:16 AM

Harbormaster completed remote builds in B29451: Diff 40981.Wed, Jun 5, 6:40 AM

inka requested review of this revision.Wed, Jun 5, 6:40 AM

tomek accepted this revision.Wed, Jun 5, 6:59 AM

tomek added inline comments.

lib/reducers/user-reducer.js
258–269 ↗	(On Diff #40981)	This can be simplified by iterating over `action.payload.userInfos` instead of creating an object from it

This revision is now accepted and ready to land.Wed, Jun 5, 6:59 AM

Address review

Harbormaster completed remote builds in B29485: Diff 41038.Thu, Jun 6, 4:53 AM

Closed by commit rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username (authored by inka). · Explain WhyTue, Jun 25, 1:21 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

32 lines

Diff 41680

lib/reducers/user-reducer.js

Loading...