Page MenuHomePhabricator
Differential D12236

[web] Stop navigating to Add Members modal from community creation
ClosedPublic
Actions

Authored by inka on May 29 2024, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 11:15 AM
Unknown Object (File)
Wed, Apr 16, 11:13 AM
Unknown Object (File)
Wed, Apr 16, 5:50 AM
Unknown Object (File)
Tue, Apr 15, 2:44 PM
Unknown Object (File)
Mar 18 2025, 10:40 PM
Unknown Object (File)
Mar 11 2025, 11:49 AM
Unknown Object (File)
Mar 4 2025, 7:55 PM
Unknown Object (File)
Mar 1 2025, 3:09 AM
View All 81 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM7e127ed8e9fc: [web] Stop navigating to Add Members modal from community creation
Summary

issue: ENG-8246

Test Plan

Tested that the modal is not appearing, and it is possible to create a new community. The user is navigated to that community

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 40963

View Options

web/sidebar/community-creation/community-creation-members-modal.css

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
+onLoad?: (uri: string) => void, +onLoad?: (uri: string) => void,
Show All 14 Lines const {
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia(); const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(authoritativeKeyserverID)); const connected = useSelector(state => state.connectivity.connected);
invariant(connection, 'keyserver missing from keyserverStore'); const prevConnectedRef = React.useRef(connected);
const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
const [errorOccured, setErrorOccured] = React.useState(false); const [errorOccured, setErrorOccured] = React.useState(false);
if (prevConnectionStatusRef.current !== connectionStatus) { if (prevConnectedRef.current !== connected) {
if (!source && connectionStatus === 'connected') { if (!source && connected) {
setAttempt(attempt + 1); setAttempt(attempt + 1);
} }
prevConnectionStatusRef.current = connectionStatus; prevConnectedRef.current = connected;
} }
const placeholder = React.useMemo(() => { const placeholder = React.useMemo(() => {
if (!encryptedThumbHash) { if (!encryptedThumbHash) {
return null; return null;
} }
try { try {
const decryptedThumbHash = decryptBase64( const decryptedThumbHash = decryptBase64(
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

web/sidebar/community-creation/community-creation-members-modal.react.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
+onLoad?: (uri: string) => void, +onLoad?: (uri: string) => void,
Show All 14 Lines const {
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia(); const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(authoritativeKeyserverID)); const connected = useSelector(state => state.connectivity.connected);
invariant(connection, 'keyserver missing from keyserverStore'); const prevConnectedRef = React.useRef(connected);
const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
const [errorOccured, setErrorOccured] = React.useState(false); const [errorOccured, setErrorOccured] = React.useState(false);
if (prevConnectionStatusRef.current !== connectionStatus) { if (prevConnectedRef.current !== connected) {
if (!source && connectionStatus === 'connected') { if (!source && connected) {
setAttempt(attempt + 1); setAttempt(attempt + 1);
} }
prevConnectionStatusRef.current = connectionStatus; prevConnectedRef.current = connected;
} }
const placeholder = React.useMemo(() => { const placeholder = React.useMemo(() => {
if (!encryptedThumbHash) { if (!encryptedThumbHash) {
return null; return null;
} }
try { try {
const decryptedThumbHash = decryptBase64( const decryptedThumbHash = decryptBase64(
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

web/sidebar/community-creation/community-creation-modal.react.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
+onLoad?: (uri: string) => void, +onLoad?: (uri: string) => void,
Show All 14 Lines const {
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia(); const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(authoritativeKeyserverID)); const connected = useSelector(state => state.connectivity.connected);
invariant(connection, 'keyserver missing from keyserverStore'); const prevConnectedRef = React.useRef(connected);
const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
const [errorOccured, setErrorOccured] = React.useState(false); const [errorOccured, setErrorOccured] = React.useState(false);
if (prevConnectionStatusRef.current !== connectionStatus) { if (prevConnectedRef.current !== connected) {
if (!source && connectionStatus === 'connected') { if (!source && connected) {
setAttempt(attempt + 1); setAttempt(attempt + 1);
} }
prevConnectionStatusRef.current = connectionStatus; prevConnectedRef.current = connected;
} }
const placeholder = React.useMemo(() => { const placeholder = React.useMemo(() => {
if (!encryptedThumbHash) { if (!encryptedThumbHash) {
return null; return null;
} }
try { try {
const decryptedThumbHash = decryptBase64( const decryptedThumbHash = decryptBase64(
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines