Differential D12328 Authored by inka on Thu, Jun 6, 3:30 AM.
Tags None Referenced Files
Subscribers
Details Summary We don't want to introdue state change if it didn't really change. This will avoid unneccesaryy rerenders Test Plan Tested that if filteredUserIDs.length === 0 the returcer returns unchanged state
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 6, 3:30 AM2024-06-06 03:30:30 (UTC-7) inka added a parent revision: D12319: [lib] Fetch user avatars for new user ids.Thu, Jun 6, 3:30 AM2024-06-06 03:30:41 (UTC-7) Harbormaster completed remote builds in B29481: Diff 41034.Thu, Jun 6, 3:46 AM2024-06-06 03:46:54 (UTC-7) inka added a child revision: D12329: [lib] Dispatch processNewUserIDsActionType.Thu, Jun 6, 3:49 AM2024-06-06 03:49:15 (UTC-7) This revision is now accepted and ready to land.Thu, Jun 6, 4:06 AM2024-06-06 04:06:02 (UTC-7) Closed by commit rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer (authored by inka). · Explain WhyTue, Jun 25, 1:21 AM2024-06-25 01:21:57 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 41682 |