[lib] Avoid unnecessary state change in user reducer
ClosedPublic
Actions

Authored by inka on Thu, Jun 6, 3:30 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer

Summary

We don't want to introdue state change if it didn't really change. This will avoid unneccesaryy rerenders

Test Plan

Tested that if filteredUserIDs.length === 0 the returcer returns unchanged state

Diff Detail

Repository

rCOMM Comm

Branch

inka/userStore

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Thu, Jun 6, 3:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 6, 3:30 AM

inka added a parent revision: D12319: [lib] Fetch user avatars for new user ids.Thu, Jun 6, 3:30 AM

Harbormaster completed remote builds in B29481: Diff 41034.Thu, Jun 6, 3:46 AM

inka requested review of this revision.Thu, Jun 6, 3:46 AM

inka added a child revision: D12329: [lib] Dispatch processNewUserIDsActionType.Thu, Jun 6, 3:49 AM

tomek accepted this revision.Thu, Jun 6, 4:06 AM

This revision is now accepted and ready to land.Thu, Jun 6, 4:06 AM

Closed by commit rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer (authored by inka). · Explain WhyTue, Jun 25, 1:21 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

22 lines

Diff 41034

View Options

lib/reducers/user-reducer.js

[lib] Avoid unnecessary state change in user reducerClosedPublicActions