Page MenuHomePhabricator

[lib][web] Extract logic checking add users permissions
ClosedPublic

Authored by inka on Jun 4 2024, 2:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 5:17 AM
Unknown Object (File)
Fri, Feb 21, 4:45 PM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
Unknown Object (File)
Jan 24 2025, 9:36 PM
Unknown Object (File)
Jan 23 2025, 5:01 AM
Subscribers

Details

Summary

This can be reused on native

Test Plan

tested that in members modal the "Add members" button is displayed when it is supposed to and navigates to proper modals

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jun 4 2024, 2:19 AM
tomek added inline comments.
lib/permissions/add-users-permissions.js
11 ↗(On Diff #40926)

How about renaming it to AddUsersPermissions?

18 ↗(On Diff #40926)

I'm not sure if this name is good, because this hook returns more than just the permissions, but I don't have any better alternative.

This revision is now accepted and ready to land.Jun 4 2024, 2:45 AM

Rename type

lib/permissions/add-users-permissions.js
18 ↗(On Diff #40926)

I'm not 100% happy with it either, but I couldn't come up with anything better