Page MenuHomePhabricator
Differential D12309

[lib][web] Extract logic checking add users permissions
ClosedPublic
Actions

Authored by inka on Jun 4 2024, 2:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 9:19 AM
Unknown Object (File)
Wed, Apr 16, 8:39 AM
Unknown Object (File)
Wed, Apr 16, 4:24 AM
Unknown Object (File)
Wed, Apr 16, 1:46 AM
Unknown Object (File)
Tue, Apr 15, 11:17 AM
Unknown Object (File)
Fri, Mar 28, 9:49 PM
Unknown Object (File)
Sat, Mar 22, 11:12 PM
Unknown Object (File)
Mar 17 2025, 5:01 PM
View All 87 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions
Summary

This can be reused on native

Test Plan

tested that in members modal the "Add members" button is displayed when it is supposed to and navigates to proper modals

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jun 4 2024, 2:03 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 4 2024, 2:03 AM
inka added a parent revision: D12237: [web] Navigate to invite links instead of add members modal.Jun 4 2024, 2:03 AM
inka added a child revision: D12284: [native] Navigate to invite links instead of add members modal.
Harbormaster completed remote builds in B29425: Diff 40926.Jun 4 2024, 2:19 AM
inka requested review of this revision.Jun 4 2024, 2:19 AM
tomek accepted this revision.Jun 4 2024, 2:45 AM
tomek added inline comments.
lib/permissions/add-users-permissions.js
11 ↗(On Diff #40926)

How about renaming it to AddUsersPermissions?

18 ↗(On Diff #40926)

I'm not sure if this name is good, because this hook returns more than just the permissions, but I don't have any better alternative.

This revision is now accepted and ready to land.Jun 4 2024, 2:45 AM
inka updated this revision to Diff 40943.Jun 4 2024, 4:48 AM

Rename type

lib/permissions/add-users-permissions.js
18 ↗(On Diff #40926)

I'm not 100% happy with it either, but I couldn't come up with anything better

Harbormaster completed remote builds in B29436: Diff 40943.Jun 4 2024, 5:05 AM
Closed by commit rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions (authored by inka). · Explain WhyJun 4 2024, 8:31 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions.

Revision Contents
Changeset List

PathSize
lib/
permissions/
41 lines
web/
modals/
threads/
members/
29 lines

Diff 40965

View Options

lib/permissions/add-users-permissions.js

Loading...
View Options

web/modals/threads/members/members-modal.react.js

Loading...