After D12285 this component wasn't used anywhre else, and we don't expect to need it in the future
Details
Details
- Reviewers
tomek kamil - Commits
- rCOMMdbf70d0f8675: [native] Remove unused componenet
flow + tested that community creation works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/community-creation/community-creation-navigator.react.js | ||
|---|---|---|
| 54–60 ↗ | (On Diff #40919) | Wondering if it makes sense to keep a navigator with just one screen. Can we replace it with just the screen? |
| native/community-creation/community-creation-navigator.react.js | ||
|---|---|---|
| 54–60 ↗ | (On Diff #40919) | That would result in changing navigation structure which results in the app crashing because of how we handle navigation state restoration. This can be fixed, but considering that I am already late two days with my May goal, and that as I remember this is not super easy, I would rather not do it |
Comment Actions
That would result in changing navigation structure which results in the app crashing because of how we handle navigation state restoration.
Note that navigation state restoration only applies on dev builds, and does not affect release builds.
That said, I think @inka's prioritization makes sense here given limited time.