[lib] Discard keyserver usernames for updateUserAvatarActionTypes
ClosedPublic
Actions

Authored by inka on Thu, Jun 20, 7:02 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMMbad3d4b3542b: [lib] Discard keyserver usernames for updateUserAvatarActionTypes

Summary

issue: ENG-8365

Test Plan

Tested that for updateUserAvatarActionTypes if the user was in the store the username is not changed. Assuming some correctness based on having tested other diffs in this stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Thu, Jun 20, 7:02 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 20, 7:02 AM

inka added a parent revision: D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.Thu, Jun 20, 7:02 AM

Harbormaster completed remote builds in B29836: Diff 41571.Thu, Jun 20, 7:18 AM

inka requested review of this revision.Thu, Jun 20, 7:18 AM

kamil accepted this revision.Fri, Jun 21, 3:34 AM

kamil added inline comments.

lib/reducers/user-reducer.js
579–582 ↗	(On Diff #41571)	A bit confusing because this code is doing basically nothing - but it's probably good to leave it to keep it consistent with other call sites

This revision is now accepted and ready to land.Fri, Jun 21, 3:34 AM

inka added inline comments.Fri, Jun 21, 5:08 AM

lib/reducers/user-reducer.js
579–582 ↗	(On Diff #41571)	Looking at the code called by `updateUserAvatarResponder` - `updateUserAvatar` -> `createUserAvatarUpdates` -> `createUpdates` is actually seems like we can get updates for some other users here. So this code could do something. And it doesn't hurt