Page MenuHomePhabricator

[lib] Fix missing usernames
ClosedPublic

Authored by inka on Jul 5 2024, 9:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 31, 5:16 AM
Unknown Object (File)
Tue, Jul 30, 1:04 PM
Unknown Object (File)
Mon, Jul 29, 11:16 AM
Unknown Object (File)
Mon, Jul 22, 6:29 AM
Unknown Object (File)
Fri, Jul 19, 5:28 AM
Unknown Object (File)
Fri, Jul 19, 5:17 AM
Unknown Object (File)
Wed, Jul 17, 9:31 PM
Unknown Object (File)
Sat, Jul 13, 8:39 PM
Subscribers
None

Details

Summary

issues: https://linear.app/comm/issue/ENG-8762/new-users-show-up-as-anonymous-in-chat-with-ashoat#comment-bc006d6a and https://linear.app/comm/issue/ENG-8722/users-were-all-anonymous-after-usingcsat=true-login-on-prod#comment-04b52d64
I am just reverting the changes made in the stack between D12352 and D12514. We don't want to discard the keyserver usernames for now, because

  1. We should never do this if usingCSAT is false
  2. If usingCSAT is true some of the user might have not migrated yet, so their usernames are not present on identity

Once we implement identity returning usernames from identity-reserved-usernames able as well, we can rever this diff and add a if(usingCSAT) check in discardKeyserverUsernames

Test Plan

Tested that after this if a new user joins comm ashoat user can see their username.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable