Paths

Table of Contentst

Differential D12680

[lib] Fix crash when pressing message from anonymous author
ClosedPublic
Actions

Authored by ashoat on Sat, Jul 6, 2:42 PM.

Tags

None

Referenced Files

	F2255243: D12680.id42088.diff
	Fri, Jul 12, 6:37 PM

	F2251387: D12680.id42116.diff
	Fri, Jul 12, 8:56 AM

	Unknown Object (File)
	Thu, Jul 11, 7:34 PM

	Unknown Object (File)
	Thu, Jul 11, 9:05 AM

	Unknown Object (File)
	Wed, Jul 10, 8:47 PM

	Unknown Object (File)
	Tue, Jul 9, 12:07 PM

	Unknown Object (File)
	Mon, Jul 8, 1:57 PM

	Unknown Object (File)
	Mon, Jul 8, 1:57 PM

View All 10 Files

Subscribers

None

Details

Reviewers

inka
tomek

Commits

rCOMMdeb4a0ed9d3e: [lib] Fix crash when pressing message from anonymous author

Summary

If we don't have a username for a message author, the app currently crashing when you press the message.

It looks like the Flow types here are unnecessarily strict. Once I relaxed them, I was able to remove the invariant.

This resolves ENG-8777.

Depends on D12679

Test Plan

I reverted D12674 to reproduce the issue. I then created a new user from a separate account, and sent a message to my main user. The main user was able to press the message, react, and start a sidebar on the messages for the other user, even though the other user showed up as "anonymous"

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sat, Jul 6, 2:42 PM

ashoat mentioned this in D12681: [lib] Don't query keyserver for empty string from useThreadListSearch.Sat, Jul 6, 2:45 PM

Harbormaster completed remote builds in B30176: Diff 42087.Sat, Jul 6, 2:58 PM

ashoat requested review of this revision.Sat, Jul 6, 2:58 PM

ashoat added a child revision: D12681: [lib] Don't query keyserver for empty string from useThreadListSearch.Sat, Jul 6, 3:12 PM

tomek accepted this revision.Mon, Jul 8, 1:44 AM

This revision is now accepted and ready to land.Mon, Jul 8, 1:44 AM

Closed by commit rCOMMdeb4a0ed9d3e: [lib] Fix crash when pressing message from anonymous author (authored by ashoat). · Explain WhyMon, Jul 8, 8:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdeb4a0ed9d3e: [lib] Fix crash when pressing message from anonymous author.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-utils.js

10 lines

thread-utils.js

4 lines

Diff 42115

lib/shared/sidebar-utils.js

Loading...

lib/shared/thread-utils.js

Loading...