Page MenuHomePhabricator
Differential D12681

[lib] Don't query keyserver for empty string from useThreadListSearch
ClosedPublic
Actions

Authored by ashoat on Jul 6 2024, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 28 2025, 9:20 PM
Unknown Object (File)
Feb 21 2025, 5:07 PM
Unknown Object (File)
Feb 21 2025, 5:07 PM
Unknown Object (File)
Feb 21 2025, 5:07 PM
Unknown Object (File)
Feb 21 2025, 5:07 PM
Unknown Object (File)
Jan 29 2025, 3:15 AM
Unknown Object (File)
Jan 23 2025, 9:47 AM
Unknown Object (File)
Jan 23 2025, 2:39 AM
View All 62 Files
Subscribers
None

Details

Reviewers
inka
tomek
Commits
rCOMMbd12ab53cebf: [lib] Don't query keyserver for empty string from useThreadListSearch
Summary

D11799 accidentally introduced a regression when replacing return [] that was previously here. It was replaced with a call to filterAndSetUserResults, but the return was accidentally dropped, causing us to query the keyserver for the empty string from here. This happens in the background repeatedly as the keyserver connection status changes.

This addresses ENG-8777

Depends on D12680

Test Plan

I added some logs: https://gist.github.com/Ashoat/4ac8c57b3359b5a33fb8ee10268ada90

They allowed me to confirm that the empty string queries were no longer going through

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
hooks/
1 line

Diff 42116

View Options

lib/hooks/thread-search-hooks.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines