Page MenuHomePhabricator

[lib] Don't query keyserver for empty string from useThreadListSearch
ClosedPublic

Authored by ashoat on Jul 6 2024, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 7:36 AM
Unknown Object (File)
Tue, Nov 12, 7:23 AM
Unknown Object (File)
Tue, Nov 12, 6:59 AM
Unknown Object (File)
Mon, Nov 11, 10:02 PM
Unknown Object (File)
Oct 21 2024, 4:30 AM
Unknown Object (File)
Oct 19 2024, 9:32 PM
Unknown Object (File)
Oct 11 2024, 4:52 AM
Unknown Object (File)
Oct 11 2024, 4:52 AM
Subscribers
None

Details

Summary

D11799 accidentally introduced a regression when replacing return [] that was previously here. It was replaced with a call to filterAndSetUserResults, but the return was accidentally dropped, causing us to query the keyserver for the empty string from here. This happens in the background repeatedly as the keyserver connection status changes.

This addresses ENG-8777

Depends on D12680

Test Plan

I added some logs: https://gist.github.com/Ashoat/4ac8c57b3359b5a33fb8ee10268ada90

They allowed me to confirm that the empty string queries were no longer going through

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable