[lib] Search for users in thread list search
ClosedPublic
Actions

Authored by inka on Apr 26 2024, 5:45 AM.

Details

Reviewers

will
tomek
ashoat

Commits

rCOMM0dedc239c178: [lib] Search for users in thread list search

Summary

issue: ENG-7315
We want the search in thread list to start querying the identity service for users

Screenshot 2024-04-26 at 12.39.18.png (1×3 px, 364 KB)

Screenshot 2024-04-26 at 12.54.52.png (1×3 px, 369 KB)

(okapi7 is a user registered on my keyserver)

Test Plan

Tested that on web and native thread list now also shows users registered with identity that the user does not know of - that are not even on my keyserver
Tested that threads that match the query are still visible as well
Tested that users that are registered with my keyserver are visible

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Apr 26 2024, 5:45 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 26 2024, 5:45 AM

inka edited the summary of this revision. (Show Details)Apr 26 2024, 5:46 AM

inka attached a referenced file: F1665712: Screenshot 2024-04-26 at 12.54.52.png. (Show Details)

inka attached a referenced file: F1665713: Screenshot 2024-04-26 at 12.39.18.png. (Show Details)

Harbormaster completed remote builds in B28499: Diff 39534.Apr 26 2024, 6:01 AM

inka requested review of this revision.Apr 26 2024, 6:01 AM

Looks good to me

This revision is now accepted and ready to land.Apr 26 2024, 7:51 PM

ashoat added inline comments.Apr 27 2024, 6:12 PM

lib/shared/thread-utils.js
1567–1568 ↗	(On Diff #39534)	Should we rename these to indicate that they are the "legacy" approach?
1603–1605 ↗	(On Diff #39534)	I feel like we should be able to avoid copy-pasting the filter logic here. What if we define a callback eg. `setSearchResults` (feel free to rethink the naming) that does the filter and then calls `setUsersSearchResults`? Then we could use that in `searchUsers`, as well as using it here.