issue: ENG-7832
updateUserAvatarActionTypes was never refactored for multiple kyeservers because we don't want to be sending avatar updates to secondary keyservers. So this action is always called for the auth keyserver
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/userStore
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Should this diff be titled something different? It doesn't seem that the title is accurate.
I'm also not clear why we need to be doing this. If the client calls updateUserAvatar when relyingOnAuthoritativeKeyserver, does we really want to ignore the result?
It seems like instead, we should just avoid calling updateUserAvatar when relyingOnAuthoritativeKeyserver.
Comment Actions
When relyingOnAuthoritativeKeyserver is true we want the client to update their avatar by calling the auth keyserver. This change makes the client disregard updateUserAvatarActionTypes if relyingOnAuthoritativeKeyserver is false, under the assumption that we would then call a different action. But actually we will probably want to reuse the action types and only change the promise used.
I think this diff should be dropped, because we will probably want to reuse the action types for peer-to-peer avatar updates, and for now we have a loose guarantee that this action is not called for a different keyserver, because the promise we use it with (updateUserAvatar) was not refactored for multiple keyservers. So it can only call the auth keyserver.