Paths

Table of Contentst

Differential D12319

[lib] Fetch user avatars for new user ids
ClosedPublic
Actions

Authored by inka on Wed, Jun 5, 6:16 AM.

Tags

None

Referenced Files

	F2106725: D12319.id40982.diff
	Tue, Jun 25, 8:40 AM

	Unknown Object (File)
	Sun, Jun 23, 6:36 AM

	Unknown Object (File)
	Fri, Jun 21, 6:42 AM

	Unknown Object (File)
	Thu, Jun 20, 10:29 AM

	Unknown Object (File)
	Wed, Jun 12, 9:16 AM

	Unknown Object (File)
	Mon, Jun 10, 7:45 PM

	Unknown Object (File)
	Mon, Jun 10, 9:05 AM

	Unknown Object (File)
	Sat, Jun 8, 9:01 AM

View All 13 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMa5db4961c568: [lib] Fetch user avatars for new user ids

Summary

issue: ENG-7823
After calling update relationships endpoint, the keyserver will generate updates and send them to the client. This way we will obtain the avatar.
For now, this action will override the username for this id if already present in the store. This will be changed in ENG-8365.

Test Plan

Dispatched processNewUserIDsActionType with user id that the current user didn't have in the store. Checked that user infos are fetched from the keyserver and saved in the store.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Wed, Jun 5, 6:16 AM

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Jun 5, 6:16 AM

inka added a parent revision: D12318: [lib] Don't remove avatar when fetching username.Wed, Jun 5, 6:16 AM

Harbormaster completed remote builds in B29452: Diff 40982.Wed, Jun 5, 6:32 AM

inka requested review of this revision.Wed, Jun 5, 6:32 AM

tomek accepted this revision.Wed, Jun 5, 6:53 AM

This revision is now accepted and ready to land.Wed, Jun 5, 6:53 AM

inka added a child revision: D12328: [lib] Avoid unnecessary state change in user reducer.Thu, Jun 6, 3:30 AM

Rebase

Harbormaster completed remote builds in B29815: Diff 41548.Thu, Jun 20, 3:00 AM

Closed by commit rCOMMa5db4961c568: [lib] Fetch user avatars for new user ids (authored by inka). · Explain WhyTue, Jun 25, 1:21 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa5db4961c568: [lib] Fetch user avatars for new user ids.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

user-infos-handler.react.js

28 lines

Diff 41681

lib/handlers/user-infos-handler.react.js

Loading...