Paths

Table of Contentst

Differential D11955

[keyserver] introduce fetchCommunityInfos
ClosedPublic
Actions

Authored by ginsu on May 9 2024, 6:56 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM07f2aa829637: [keyserver] introduce fetchCommunityInfos

Summary

This diff introduces fetchCommunityInfos. fetchCommunityInfos returns all the communites where the viewer where the viewer is a member

Linear task: https://linear.app/comm/issue/ENG-7916/introduce-community-info-fetchers

Depends on D11954

Test Plan

Tested calling this endpoint from the client w/ several different accounts

User account w/ no community memberships (just GENESIS):

[NODEM] communityInfos [
[NODEM] 	{
[NODEM] 		"id": "1",
[NODEM] 		"farcasterChannelID": null,
[NODEM] 		"blobHolder": null
[NODEM] 	}
[NODEM] ]

User account w/ 1 community membership + GENESIS:

[NODEM] communityInfos [
[NODEM] 	{
[NODEM] 		"id": "1",
[NODEM] 		"farcasterChannelID": null,
[NODEM] 		"blobHolder": null
[NODEM] 	},
[NODEM] 	{
[NODEM] 		"id": "83943",
[NODEM] 		"farcasterChannelID": null,
[NODEM] 		"blobHolder": null
[NODEM] 	}
[NODEM] ]

User account w/ 2 community memberships + GENESIS:

[NODEM] communityInfos [
[NODEM] 	{
[NODEM] 		"id": "1",
[NODEM] 		"farcasterChannelID": null,
[NODEM] 		"blobHolder": null
[NODEM] 	},
[NODEM] 	{
[NODEM] 		"id": "83887",
[NODEM] 		"farcasterChannelID": "farcaster",
[NODEM] 		"blobHolder": "89e7240a-c869-4896-b6ae-392d1dce20f4"
[NODEM] 	},
[NODEM] 	{
[NODEM] 		"id": "83943",
[NODEM] 		"farcasterChannelID": null,
[NODEM] 		"blobHolder": null
[NODEM] 	}
[NODEM] ]

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.May 9 2024, 6:56 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 9 2024, 6:56 AM

ginsu edited the summary of this revision. (Show Details)May 9 2024, 7:00 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: tomek, kamil.

ginsu added a parent revision: D11954: [lib/web] update CommunityInfo type.

Harbormaster completed remote builds in B28777: Diff 39965.May 9 2024, 7:12 AM

ginsu requested review of this revision.May 9 2024, 7:12 AM

tomek accepted this revision.May 9 2024, 11:00 AM

tomek added inline comments.

keyserver/src/fetchers/community-fetchers.js
8–12 ↗	(On Diff #39965)	We should make this readonly because spreading a type makes it writable.
32–38 ↗	(On Diff #39965)

This revision is now accepted and ready to land.May 9 2024, 11:00 AM

ginsu added a child revision: D11975: [keyserver/lib] upate createOrUpdateFarcasterChannelTag to use communites table.May 9 2024, 4:26 PM

address comments

Harbormaster completed remote builds in B28824: Diff 40040.May 9 2024, 8:25 PM

ashoat added inline comments.May 10 2024, 12:02 AM

keyserver/src/fetchers/community-fetchers.js
17 ↗	(On Diff #40040)	This check doesn't make sense. Did you mean to check `loggedIn`?

address comments + rebase before landing

ginsu mentioned this in D12060: [keyserver/lib/web] include communityStore in the initialReduxState.May 20 2024, 9:54 AM

This revision was landed with ongoing or failed builds.May 20 2024, 9:58 AM

Closed by commit rCOMM07f2aa829637: [keyserver] introduce fetchCommunityInfos. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM07f2aa829637: [keyserver] introduce fetchCommunityInfos.

Harbormaster completed remote builds in B29040: Diff 40372.May 20 2024, 10:07 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

community-fetchers.js

41 lines

Diff 40376

keyserver/src/fetchers/community-fetchers.js

Loading...