issue: ENG-8246
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 43 ↗ | (On Diff #40871) | We cannot remove props because of react navigation. We do the same in other components, for example AppsDirectory |
| 107 ↗ | (On Diff #40871) | Before, we would navigate to CommunityCreationMembersRouteName, where upon pressing "Add" or "Cancel" (the only two buttons allowing us to leave the screen) navigateToThread would be called. We want to do this right away, since we don't want to allow adding users to community roots |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 30 ↗ | (On Diff #40871) | Is this route used anywhere else, or should it be deleted? |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 106–107 ↗ | (On Diff #40871) | Is it possible that communityThreadInfo will still be null here? Should we navigate conditionally, only when the thread info is present? |