Paths

Table of Contentst

Differential D12285

[native] Stop navigating to Add Members from community creation
ClosedPublic
Actions

Authored by inka on Mon, Jun 3, 8:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 1:34 AM

	Unknown Object (File)
	Sun, Jun 23, 1:15 AM

	Unknown Object (File)
	Fri, Jun 21, 10:35 PM

	Unknown Object (File)
	Thu, Jun 20, 9:42 AM

	Unknown Object (File)
	Tue, Jun 18, 1:39 PM

	Unknown Object (File)
	Tue, Jun 11, 6:47 AM

	Unknown Object (File)
	Mon, Jun 10, 5:03 AM

	Unknown Object (File)
	Mon, Jun 10, 4:57 AM

View All 21 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM4b5b50a21e6d: [native] Stop navigating to Add Members from community creation

Summary

issue: ENG-8246

Test Plan

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mon, Jun 3, 8:01 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 3, 8:01 AM

inka added a parent revision: D12284: [native] Navigate to invite links instead of add members modal.Mon, Jun 3, 8:01 AM

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F1942676: Screen Recording 2024-06-03 at 16.53.15.mov. (Show Details)

inka added inline comments.Mon, Jun 3, 8:04 AM

native/community-creation/community-configuration.react.js
43 ↗	(On Diff #40871)	We cannot remove props because of react navigation. We do the same in other components, for example `AppsDirectory`
107 ↗	(On Diff #40871)	Before, we would navigate to `CommunityCreationMembersRouteName`, where upon pressing "Add" or "Cancel" (the only two buttons allowing us to leave the screen) `navigateToThread` would be called. We want to do this right away, since we don't want to allow adding users to community roots

Harbormaster completed remote builds in B29379: Diff 40871.Mon, Jun 3, 8:18 AM

inka requested review of this revision.Mon, Jun 3, 8:18 AM

inka added a child revision: D12286: [native] Fetch invite links when entering thread settings.Mon, Jun 3, 8:34 AM

ashoat added inline comments.Mon, Jun 3, 10:01 AM

native/community-creation/community-configuration.react.js
30 ↗	(On Diff #40871)	Is this route used anywhere else, or should it be deleted?

tomek accepted this revision.Tue, Jun 4, 1:09 AM

tomek added inline comments.

native/community-creation/community-configuration.react.js
106–107 ↗	(On Diff #40871)	Is it possible that `communityThreadInfo` will still be null here? Should we navigate conditionally, only when the thread info is present?

This revision is now accepted and ready to land.Tue, Jun 4, 1:09 AM

inka mentioned this in D12306: [native] Remove unused componenet.Tue, Jun 4, 1:15 AM

inka added inline comments.Tue, Jun 4, 1:16 AM

native/community-creation/community-configuration.react.js
30 ↗	(On Diff #40871)	We can remove it D12306

Check if thread info is present

Harbormaster completed remote builds in B29423: Diff 40924.Tue, Jun 4, 1:56 AM

Closed by commit rCOMM4b5b50a21e6d: [native] Stop navigating to Add Members from community creation (authored by inka). · Explain WhyTue, Jun 4, 8:31 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM4b5b50a21e6d: [native] Stop navigating to Add Members from community creation.

inka mentioned this in rCOMMdbf70d0f8675: [native] Remove unused componenet.

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

40 lines

Diff 40966

native/community-creation/community-configuration.react.js

Loading...