Paths

Table of Contentst

Differential D12509

[lib] Discard keyserver usernames for keyserverAuthActionTypes
ClosedPublic
Actions

Authored by inka on Thu, Jun 20, 4:16 AM.

Tags

None

Referenced Files

	F2129401: D12509.id41598.diff
	Thu, Jun 27, 1:05 PM

	F2127855: D12509.id41552.diff
	Thu, Jun 27, 9:15 AM

	F2124430: D12509.id41551.diff
	Wed, Jun 26, 8:57 PM

	Unknown Object (File)
	Tue, Jun 25, 1:39 PM

	Unknown Object (File)
	Tue, Jun 25, 12:33 PM

	Unknown Object (File)
	Mon, Jun 24, 10:57 PM

	Unknown Object (File)
	Mon, Jun 24, 2:39 PM

	Unknown Object (File)
	Sun, Jun 23, 6:44 PM

View All 10 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMd442aff70ff5: [lib] Discard keyserver usernames for keyserverAuthActionTypes

Summary

issue: ENG-8365
update_relationships throws for viewers own id, because it doesn't make sense to be updating users relationship with themselves. But the user should always have their own user info sent during keyserver auth, so there is no need to fetch it, for any action

Test Plan

Logged in. Checked that usernames for both the current user and other users are null after keyserver auth and get fetched from identity. Checked that the invalid_user error doesn't show up.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Thu, Jun 20, 4:16 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 20, 4:16 AM

Harbormaster completed remote builds in B29817: Diff 41550.Thu, Jun 20, 4:32 AM

inka requested review of this revision.Thu, Jun 20, 4:32 AM

inka added a parent revision: D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.Thu, Jun 20, 4:35 AM

inka added a child revision: D12510: [lib] Discard keyserver usernames for full state sync.

inka added inline comments.Thu, Jun 20, 4:41 AM

lib/handlers/user-infos-handler.react.js
71–73 ↗	(On Diff #41550)	I should check again if `userIDsWithoutOwnID` is not empty

Check if empty

Harbormaster completed remote builds in B29861: Diff 41596.Fri, Jun 21, 12:31 AM

kamil accepted this revision.Fri, Jun 21, 3:24 AM

This revision is now accepted and ready to land.Fri, Jun 21, 3:24 AM

Closed by commit rCOMMd442aff70ff5: [lib] Discard keyserver usernames for keyserverAuthActionTypes (authored by inka). · Explain WhyTue, Jun 25, 1:22 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMd442aff70ff5: [lib] Discard keyserver usernames for keyserverAuthActionTypes.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

user-infos-handler.react.js

11 lines

reducers/

user-reducer.js

6 lines

Diff 41687

lib/handlers/user-infos-handler.react.js

Loading...

lib/reducers/user-reducer.js

Loading...