Differential D12025

[native] display loading spinner in TagChannelButton during loading state
ClosedPublic
Actions

Authored by ginsu on May 13 2024, 11:34 PM.

Details

Reviewers

tomek
inka

Commits

rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state

Summary

When a farcaster channel tag is being created/updated we should show a loading spinner to the user to indicate that their request is currently being handled

Depends on D12024

Test Plan

Confirmed that a loading spinner would be displayed during the loading state

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.May 13 2024, 11:34 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 13 2024, 11:34 PM

ginsu edited the summary of this revision. (Show Details)May 13 2024, 11:35 PM

ginsu added reviewers: tomek, inka.

ginsu added a parent revision: D12024: [native] introduce TagChannelButton.

Harbormaster completed remote builds in B28889: Diff 40148.May 13 2024, 11:50 PM

ginsu requested review of this revision.May 13 2024, 11:50 PM

ginsu added a child revision: D12027: [lib] update community reducer to handle new community action types.May 13 2024, 11:53 PM

tomek accepted this revision.May 14 2024, 3:29 AM

This revision is now accepted and ready to land.May 14 2024, 3:29 AM

ginsu mentioned this in D11894: [native] introduce tag channel by name option in action sheet.May 15 2024, 2:40 PM

rebase before landing

Harbormaster completed remote builds in B29474: Diff 41009.Jun 5 2024, 11:36 PM

Closed by commit rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state (authored by ginsu). · Explain WhyJun 5 2024, 11:57 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state.

Revision Contents
Changeset List

Path

Size

native/

community-settings/

tag-farcaster-channel/

tag-channel-button.react.js

39 lines

Diff 41019

View Options

native/community-settings/tag-farcaster-channel/tag-channel-button.react.js

// @flow		// @flow

import { AppState as NativeAppState, Alert } from 'react-native';		import { AppState as NativeAppState, Alert } from 'react-native';
import { createStore, applyMiddleware, type Store, compose } from 'redux';		import { createStore, applyMiddleware, type Store, compose } from 'redux';
import { persistStore, persistReducer } from 'redux-persist';		import { persistStore, persistReducer } from 'redux-persist';
import thunk from 'redux-thunk';		import thunk from 'redux-thunk';

import { setClientDBStoreActionType } from 'lib/actions/client-db-store-actions.js';		import { setClientDBStoreActionType } from 'lib/actions/client-db-store-actions.js';
import { siweAuthActionTypes } from 'lib/actions/siwe-actions.js';		import { siweAuthActionTypes } from 'lib/actions/siwe-actions.js';
import {		import {
logOutActionTypes,		logOutActionTypes,
deleteAccountActionTypes,		deleteAccountActionTypes,
logInActionTypes,		logInActionTypes,
keyserverAuthActionTypes,		keyserverAuthActionTypes,
deleteKeyserverAccountActionTypes,		deleteKeyserverAccountActionTypes,
		identityRegisterActionTypes,
} from 'lib/actions/user-actions.js';		} from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';		import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import type { ThreadStoreOperation } from 'lib/ops/thread-store-ops.js';		import type { ThreadStoreOperation } from 'lib/ops/thread-store-ops.js';
import { threadStoreOpsHandlers } from 'lib/ops/thread-store-ops.js';		import { threadStoreOpsHandlers } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';		import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js';		import baseReducer from 'lib/reducers/master-reducer.js';
import {		import {
invalidSessionDowngrade,		invalidSessionDowngrade,
invalidSessionRecovery,		invalidSessionRecovery,
} from 'lib/shared/session-utils.js';		} from 'lib/shared/session-utils.js';
import { isStaff } from 'lib/shared/staff-utils.js';		import { isStaff } from 'lib/shared/staff-utils.js';
import type { Dispatch, BaseAction } from 'lib/types/redux-types.js';		import type { Dispatch, BaseAction } from 'lib/types/redux-types.js';
import { rehydrateActionType } from 'lib/types/redux-types.js';		import { rehydrateActionType } from 'lib/types/redux-types.js';
import type { SetSessionPayload } from 'lib/types/session-types.js';		import type { SetSessionPayload } from 'lib/types/session-types.js';
import { reduxLoggerMiddleware } from 'lib/utils/action-logger.js';		import { reduxLoggerMiddleware } from 'lib/utils/action-logger.js';
		import { resetUserSpecificStateOnIdentityActions } from 'lib/utils/reducers-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';		import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';

import {		import {
updateDimensionsActiveType,		updateDimensionsActiveType,
updateConnectivityActiveType,		updateConnectivityActiveType,
updateDeviceCameraInfoActionType,		updateDeviceCameraInfoActionType,
updateDeviceOrientationActionType,		updateDeviceOrientationActionType,
backgroundActionTypes,		backgroundActionTypes,
setReduxStateActionType,		setReduxStateActionType,
setStoreLoadedActionType,		setStoreLoadedActionType,
type Action,		type Action,
setLocalSettingsActionType,		setLocalSettingsActionType,
} from './action-types.js';		} from './action-types.js';
import { defaultState } from './default-state.js';		import { defaultState } from './default-state.js';
import { remoteReduxDevServerConfig } from './dev-tools.js';		import { remoteReduxDevServerConfig } from './dev-tools.js';
import { persistConfig, setPersistor } from './persist.js';		import { persistConfig, setPersistor } from './persist.js';
import { onStateDifference } from './redux-debug-utils.js';		import { onStateDifference } from './redux-debug-utils.js';
import { processDBStoreOperations } from './redux-utils.js';		import { processDBStoreOperations } from './redux-utils.js';
		import { nonUserSpecificFieldsNative } from './state-types.js';
import type { AppState } from './state-types.js';		import type { AppState } from './state-types.js';
import { getGlobalNavContext } from '../navigation/icky-global.js';		import { getGlobalNavContext } from '../navigation/icky-global.js';
import { activeMessageListSelector } from '../navigation/nav-selectors.js';		import { activeMessageListSelector } from '../navigation/nav-selectors.js';
import reactotron from '../reactotron.js';		import reactotron from '../reactotron.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js';		import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js';
import { isStaffRelease } from '../utils/staff-utils.js';		import { isStaffRelease } from '../utils/staff-utils.js';
import { getDevServerHostname } from '../utils/url-utils.js';		import { getDevServerHostname } from '../utils/url-utils.js';

▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines	function reducer(state: AppState = defaultState, action: Action) {
if (		if (
(action.type === setNewSessionActionType &&		(action.type === setNewSessionActionType &&
invalidSessionDowngrade(		invalidSessionDowngrade(
state,		state,
action.payload.sessionChange.currentUserInfo,		action.payload.sessionChange.currentUserInfo,
action.payload.preRequestUserState,		action.payload.preRequestUserState,
action.payload.keyserverID,		action.payload.keyserverID,
)) \|\|		)) \|\|
(action.type === logOutActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) \|\|
(action.type === deleteKeyserverAccountActionTypes.success &&		(action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade(		invalidSessionDowngrade(
state,		state,
action.payload.currentUserInfo,		action.payload.currentUserInfo,
action.payload.preRequestUserState,		action.payload.preRequestUserState,
ashoatKeyserverID,		ashoatKeyserverID,
)) \|\|		))
(action.type === deleteAccountActionTypes.success &&		) {
		return {
		...state,
		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
		};
		} else if (
		action.type === logOutActionTypes.success \|\|
		action.type === deleteAccountActionTypes.success
		) {
		if (
invalidSessionDowngrade(		invalidSessionDowngrade(
state,		state,
action.payload.currentUserInfo,		action.payload.currentUserInfo,
action.payload.preRequestUserState,		action.payload.preRequestUserState,
ashoatKeyserverID,		ashoatKeyserverID,
))		)
) {		) {
return {		return {
...state,		...state,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
};		};
}		}

		state = resetUserSpecificStateOnIdentityActions(
		state,
		defaultState,
		nonUserSpecificFieldsNative,
		);
		} else if (action.type === identityRegisterActionTypes.success) {
		state = resetUserSpecificStateOnIdentityActions(
		state,
		defaultState,
		nonUserSpecificFieldsNative,
		);
		}
if (		if (
(action.type === setNewSessionActionType &&		(action.type === setNewSessionActionType &&
action.payload.sessionChange.currentUserInfo &&		action.payload.sessionChange.currentUserInfo &&
invalidSessionRecovery(		invalidSessionRecovery(
state,		state,
action.payload.sessionChange.currentUserInfo,		action.payload.sessionChange.currentUserInfo,
action.payload.logInActionSource,		action.payload.logInActionSource,
)) \|\|		)) \|\|
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines

[native] display loading spinner in TagChannelButton during loading stateClosedPublicActions