Page MenuHomePhabricator

[keyserver/lib] update joinThread to handle auto joining from farcaster channels
AbandonedPublic

Authored by ginsu on May 15 2024, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:50 PM
Unknown Object (File)
Thu, Dec 12, 11:14 AM
Unknown Object (File)
Fri, Dec 6, 2:50 AM
Unknown Object (File)
Mon, Nov 25, 7:03 AM
Unknown Object (File)
Sat, Nov 23, 7:44 PM
Unknown Object (File)
Nov 14 2024, 12:34 PM
Unknown Object (File)
Nov 14 2024, 9:38 AM
Unknown Object (File)
Nov 7 2024, 12:16 PM
Subscribers

Details

Reviewers
tomek
kamil
ashoat
Summary

Since users who will get auto-joined won't have the permission to join the community, we need to include an override + a seperate check to make sure that the farcaster channel id included in the request by the user is valid

Linear task: https://linear.app/comm/issue/ENG-8097/extend-farcaster-data-handler-to-dispatch-all-the-join-thread-action

Depends on D12063

Test Plan

Confirmed that when the user passed in a farcasterChannelID they could use the join thread endpoint

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

keyserver/src/updaters/thread-updaters.js
841

This was intentional

ginsu requested review of this revision.May 15 2024, 8:18 PM
ashoat requested changes to this revision.May 16 2024, 11:09 AM
ashoat added inline comments.
keyserver/src/responders/thread-responders.js
182

Passing this data to the keyserver makes no sense. The keyserver already has it, and it's providing any security benefit (like inviteLinkSecret is)

keyserver/src/updaters/thread-updaters.js
820–824

Why are we querying for this if we don't need it?

This revision now requires changes to proceed.May 16 2024, 11:09 AM

This diff is no longer relevant and can be abandoned.