Page MenuHomePhabricator

[lib/web] update CommunityInfo type
ClosedPublic

Authored by ginsu on May 8 2024, 11:40 PM.
Tags
None
Referenced Files
F3495535: D11954.id40374.diff
Thu, Dec 19, 9:02 AM
F3495534: D11954.id40371.diff
Thu, Dec 19, 9:02 AM
F3495533: D11954.id39963.diff
Thu, Dec 19, 9:02 AM
F3495528: D11954.id.diff
Thu, Dec 19, 9:01 AM
F3495526: D11954.diff
Thu, Dec 19, 9:01 AM
Unknown Object (File)
Thu, Dec 5, 8:33 AM
Unknown Object (File)
Wed, Nov 20, 3:12 PM
Unknown Object (File)
Wed, Nov 20, 11:51 AM
Subscribers

Details

Summary

Updated CommunityInfo to better match the keyserver communites table db schema

Initially the enabledApps field was introduced as part of my work with the web app redesign project that we have pinned for the moment. I removed it in this diff for multiple reasons:

  1. Uncertainty of the timeline of when we will pick up the web app redesign project again.
  2. By that point we may get feedback from our farcaster launch to go in another direction with how we should utilize the enabled apps concept within Comm (also noticed today that we plan to make the calendar app permanent and get ride of the Apps tab
  3. Having an enabled apps field here that does nothing right now could cause some confusion for any dev who works with the communities code, especially since today the enabled apps are something more globally based rather than community based
  4. When we pick up the web app redesign again and realize we actually do want the enabledApps field we can always just reintroduce it w/ minimal extra work

Depends on D11904

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.May 8 2024, 11:56 PM
This revision is now accepted and ready to land.May 9 2024, 3:56 AM
This revision was landed with ongoing or failed builds.May 20 2024, 2:58 AM
This revision was automatically updated to reflect the committed changes.