[native] Navigate to invite links instead of add members modal
ClosedPublic
Actions

Authored by inka on Mon, Jun 3, 6:56 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM7abf25a3f9ea: [native] Navigate to invite links instead of add members modal

Summary

issue: ENG-7793
We don't want users to be able to add users to community roots - invite links should be used instead.

Test Plan

[for non-community-root] Tested that for chats the "Add members" button still navigates to "Add members" modal.
[for community root] Tested that if invite link exists, "Add members" button navigates to "Invite link" modal.
[for community root] Tested that if invite link doesn't exist, but user has permissions to create one, "Add members" button navigates to "Manage invite links" modal.
[for community root] Tested that if invite link doesn't exist and the user doesn't have premissions to creat it, the button is disabled.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mon, Jun 3, 6:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 3, 6:56 AM

inka added a parent revision: D12237: [web] Navigate to invite links instead of add members modal.Mon, Jun 3, 6:56 AM

inka edited the summary of this revision. (Show Details)

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F1942041: Screen Recording 2024-06-03 at 15.47.15.mov. (Show Details)

inka edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B29371: Diff 40859.Mon, Jun 3, 7:17 AM

inka requested review of this revision.Mon, Jun 3, 7:17 AM

tomek accepted this revision.Mon, Jun 3, 7:52 AM

tomek added inline comments.

native/chat/settings/thread-settings.react.js
1316–1332 ↗	(On Diff #40859)	I've seen a similar logic somewhere in the stack. Can we reuse it?
native/invite-links/invite-links-navigator.react.js
55–57 ↗	(On Diff #40859)
61–63 ↗	(On Diff #40859)