Page MenuHomePhabricator

[native] Navigate to invite links instead of add members modal
ClosedPublic

Authored by inka on Jun 3 2024, 6:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 11:53 AM
Unknown Object (File)
Sat, Dec 14, 7:26 PM
Unknown Object (File)
Sat, Dec 14, 3:17 PM
Unknown Object (File)
Tue, Dec 10, 6:45 AM
Unknown Object (File)
Sun, Dec 8, 1:00 PM
Unknown Object (File)
Wed, Nov 20, 7:17 PM
Unknown Object (File)
Nov 12 2024, 1:09 PM
Unknown Object (File)
Nov 12 2024, 9:38 AM
Subscribers

Details

Summary

issue: ENG-7793
We don't want users to be able to add users to community roots - invite links should be used instead.

Test Plan

[for non-community-root] Tested that for chats the "Add members" button still navigates to "Add members" modal.
[for community root] Tested that if invite link exists, "Add members" button navigates to "Invite link" modal.
[for community root] Tested that if invite link doesn't exist, but user has permissions to create one, "Add members" button navigates to "Manage invite links" modal.
[for community root] Tested that if invite link doesn't exist and the user doesn't have premissions to creat it, the button is disabled.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka edited the summary of this revision. (Show Details)
inka edited the test plan for this revision. (Show Details)
inka edited the summary of this revision. (Show Details)
inka requested review of this revision.Jun 3 2024, 7:17 AM
tomek added inline comments.
native/chat/settings/thread-settings.react.js
1316–1332 ↗(On Diff #40859)

I've seen a similar logic somewhere in the stack. Can we reuse it?

native/invite-links/invite-links-navigator.react.js
55–57 ↗(On Diff #40859)
61–63 ↗(On Diff #40859)
This revision is now accepted and ready to land.Jun 3 2024, 7:52 AM
inka edited the test plan for this revision. (Show Details)

Fix types