[lib] Discard keyserver usernames for full state sync
ClosedPublic
Actions

Authored by inka on Jun 20 2024, 4:34 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM96396357b076: [lib] Discard keyserver usernames for full state sync

Summary

issue: ENG-8365

Test Plan

Checked that if users are not present in the store, their user infos are added without usernames. Checked that if they are present, their usernames don't change

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 20 2024, 4:34 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 20 2024, 4:34 AM

inka added a parent revision: D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.Jun 20 2024, 4:35 AM

Harbormaster completed remote builds in B29824: Diff 41557.Jun 20 2024, 4:57 AM

inka requested review of this revision.Jun 20 2024, 4:57 AM

inka added a child revision: D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.Jun 20 2024, 4:57 AM

kamil accepted this revision.Jun 21 2024, 3:25 AM

This revision is now accepted and ready to land.Jun 21 2024, 3:25 AM

Closed by commit rCOMM96396357b076: [lib] Discard keyserver usernames for full state sync (authored by inka). · Explain WhyJun 25 2024, 1:22 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM96396357b076: [lib] Discard keyserver usernames for full state sync.

What happens if the client first becomes aware of a particular user in fullStateSyncActionType? Will we commit the ID and avatar to UserStore (but not the username), and then later fetch the username from identity?

I spoke to @inka about this in a 1:1 and they confirmed my assessment above.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

6 lines

Diff 41688

View Options

lib/reducers/user-reducer.js

	FROM rust:1.75-bullseye			FROM rust:1.76-bullseye

	RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \			RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
	build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \			build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
	gnupg software-properties-common python3-pip			gnupg software-properties-common python3-pip

	# These steps are required to install terraform			# These steps are required to install terraform
	RUN wget -O- https://apt.releases.hashicorp.com/gpg \| \			RUN wget -O- https://apt.releases.hashicorp.com/gpg \| \
	gpg --dearmor \| \			gpg --dearmor \| \
	▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

[lib] Discard keyserver usernames for full state syncClosedPublicActions