[native] show error message for tag farcaster channel errors
ClosedPublic
Actions

Authored by ginsu on Fri, Apr 26, 12:03 PM.

Details

Reviewers

atul
inka
ashoat

Commits

rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors

Summary

This diff improves the error handling for creating a farcaster tag blob. If there is an error we will display a message to the user for why the request failed

Depends on D11793

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Fri, Apr 26, 12:03 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Apr 26, 12:03 PM

This diff introduces new copy

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
26 ↗	(On Diff #39586)	This copy needs to be reviewed
164 ↗	(On Diff #39586)	Copy needs to be reviewed

ginsu mentioned this in D11793: [native] introduce tag farcaster button.Fri, Apr 26, 12:13 PM

Harbormaster completed remote builds in B28531: Diff 39586.Fri, Apr 26, 12:27 PM

ginsu requested review of this revision.Fri, Apr 26, 12:27 PM

ginsu added a child revision: D11813: [keyserver] introduce deleteFarcasterChannelTag.Fri, Apr 26, 12:34 PM

Copy looks okay. Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time

inka accepted this revision.Tue, Apr 30, 8:58 AM

inka added inline comments.

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
94 ↗	(On Diff #39586)	Can we move this to `onOptionSelected`? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked

This revision is now accepted and ready to land.Tue, Apr 30, 8:58 AM

address comments + rebase before landing

Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time

Agree this would be nice to have, but also agree that this should be considered out of scope for now. I created a linear task to track this piece of feedback:

https://linear.app/comm/issue/ENG-8032/filter-list-of-taken-farcaster-channels

This revision was landed with ongoing or failed builds.Tue, Apr 30, 9:23 AM

Closed by commit rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors.

Harbormaster completed remote builds in B28604: Diff 39698.Tue, Apr 30, 9:33 AM

ginsu mentioned this in D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.Mon, May 6, 12:17 AM