Paths

Table of Contentst

Differential D11772

[keyserver] introduce barebones createOrUpdateFarcasterChannelTag
ClosedPublic
Actions

Authored by ginsu on Wed, Apr 24, 11:12 PM.

Tags

None

Referenced Files

	F1712005: D11772.id39509.diff
	Tue, May 7, 12:22 AM

	Unknown Object (File)
	Mon, May 6, 6:44 PM

	Unknown Object (File)
	Mon, May 6, 3:10 PM

	Unknown Object (File)
	Thu, May 2, 7:17 PM

	Unknown Object (File)
	Thu, May 2, 10:53 AM

	Unknown Object (File)
	Wed, May 1, 1:54 PM

	Unknown Object (File)
	Wed, May 1, 12:37 PM

	Unknown Object (File)
	Tue, Apr 30, 7:00 PM

Subscribers

Details

Reviewers

bartek
atul
tomek

Commits

rCOMM5a19bd32d3c4: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag

Summary

This diff introduces the barebones createOrUpdateFarcasterChannelTag function. For the scope of this project we just want this function to upload a mapping of farcaster channel => comm community to the blob service for now, with the intention that all the other necessary parts for this function like (permissions, inserting the blob holder in the keyserver will be addressed and added to this function as a follow up project that I will start shortly)

Linear task: https://linear.app/comm/issue/ENG-7575/introduce-uploadfarcasterchannelblob-function and https://linear.app/comm/issue/ENG-7581/introduce-getfarcasterchannelblob-function

Test Plan

In my local stack I was able to use createOrUpdateFarcasterChannelTag to upload the farcaster channel => comm community blob and got the expected response back.

I also confirmed that when I tried to reuse the same farcaster channel tag I would trigger the already_in_use error which is expected

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Apr 24, 11:12 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 24, 11:13 PM

ginsu edited the summary of this revision. (Show Details)Wed, Apr 24, 11:20 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: bartek, atul, tomek.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Wed, Apr 24, 11:25 PM

ginsu added a child revision: D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Harbormaster completed remote builds in B28456: Diff 39473.Wed, Apr 24, 11:29 PM

ginsu requested review of this revision.Wed, Apr 24, 11:29 PM

tomek accepted this revision.Thu, Apr 25, 6:54 AM

This revision is now accepted and ready to land.Thu, Apr 25, 6:54 AM

rebase before landing

This revision was landed with ongoing or failed builds.Thu, Apr 25, 1:31 PM

Closed by commit rCOMM5a19bd32d3c4: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM5a19bd32d3c4: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.

Harbormaster completed remote builds in B28479: Diff 39508.Thu, Apr 25, 1:44 PM

ginsu added a child revision: D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.Fri, Apr 26, 11:54 AM

ginsu removed a child revision: D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

farcaster-channel-tag-creator.js

89 lines

lib/

types/

community-types.js

10 lines

Diff 39509

keyserver/src/creators/farcaster-channel-tag-creator.js

Loading...

lib/types/community-types.js

Loading...