[lib] introduce useDeleteFarcasterChannelTag
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 7:58 PM.

Details

Reviewers

atul
bartek
tomek

Commits

rCOMMa7783725d1fd: [lib] introduce useDeleteFarcasterChannelTag

Summary

This diff introduces useDeleteFarcasterChannelTag which is the actual action logic that we are running when we dispatch deleteFarcasterChannelTagActionTypes

Depends on D11815

Test Plan

Locally I was able to confirm that when I dispatched deleteFarcasterChannelTagActionTypes I would call the delete_farcaster_channel_tag endpoint and get the expected behavoir

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2024, 7:58 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 7:58 PM

ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 7:58 PM

ginsu added a parent revision: D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.

ginsu added reviewers: atul, bartek, tomek.Apr 26 2024, 8:10 PM

Harbormaster completed remote builds in B28544: Diff 39600.Apr 26 2024, 8:30 PM

ginsu requested review of this revision.Apr 26 2024, 8:30 PM

tomek accepted this revision.Apr 29 2024, 8:31 AM

tomek added inline comments.

lib/actions/community-actions.js
86–88 ↗	(On Diff #39600)	It would be easier to review this and the last diff if they were merged together. They are tightly coupled, e.g. the payload of the successful action can't be verified in the last diff without this one. (But it doesn't make sense to merge them now.)