Page MenuHomePhabricator
Differential D11814

[keyserver/lib] introduce delete_farcaster_channel_tag endpoint
ClosedPublic
Actions

Authored by ginsu on Fri, Apr 26, 12:43 PM.
Tags
None
Referenced Files
F1712481: D11814.id.diff
Tue, May 7, 3:22 AM
F1711410: D11814.id39729.diff
Mon, May 6, 10:28 PM
Unknown Object (File)
Mon, May 6, 12:53 AM
Unknown Object (File)
Mon, May 6, 12:53 AM
Unknown Object (File)
Thu, May 2, 5:31 PM
Unknown Object (File)
Thu, May 2, 3:10 AM
Unknown Object (File)
Tue, Apr 30, 6:03 PM
Subscribers
ashoat
tomek

Details

Reviewers
atul
bartek
tomek
Commits
rCOMMffc0c01586ef: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint
Summary

This diff introduces the delete_farcaster_channel_tag endpoint so that we can call the deleteFarcasterChannelTag we just introduced

Depends on D11813

Test Plan

In my local stack I was able to call the delete_farcaster_channel_tag endpoint and use the deleteFarcasterChannelTag from the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Fri, Apr 26, 12:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Apr 26, 12:43 PM
ginsu added inline comments.Fri, Apr 26, 12:44 PM
keyserver/src/responders/farcaster-channel-tag-responders.js
39 ↗(On Diff #39593)

In my next project, we will refactor this so the blob holder is no longer part of the request

ginsu edited the summary of this revision. (Show Details)Fri, Apr 26, 12:45 PM
ginsu added reviewers: atul, bartek, tomek.
ginsu added a parent revision: D11813: [keyserver] introduce deleteFarcasterChannelTag.
ginsu added a child revision: D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.Fri, Apr 26, 12:48 PM
Harbormaster completed remote builds in B28537: Diff 39593.Fri, Apr 26, 12:58 PM
ginsu requested review of this revision.Fri, Apr 26, 12:58 PM
tomek accepted this revision.Mon, Apr 29, 1:22 AM
tomek added inline comments.
keyserver/src/responders/farcaster-channel-tag-responders.js
35–52 ↗(On Diff #39593)

We should maintain consistency of our exports

This revision is now accepted and ready to land.Mon, Apr 29, 1:22 AM
ginsu updated this revision to Diff 39729.Wed, May 1, 10:42 PM

address comments + rebase before landing

This revision was landed with ongoing or failed builds.Wed, May 1, 10:52 PM
Closed by commit rCOMMffc0c01586ef: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMffc0c01586ef: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
Harbormaster completed remote builds in B28622: Diff 39729.Wed, May 1, 10:58 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
8 lines
responders/
28 lines
lib/
types/
1 line

Diff 39734

View Options

keyserver/src/endpoints.js

Loading...
View Options

keyserver/src/responders/farcaster-channel-tag-responders.js

Loading...
View Options

lib/types/endpoints.js

Loading...