Page MenuHomePhabricator
Differential D11785

[native] introduce TagFarcasterChannelParams
ClosedPublic
Actions

Authored by ginsu on Apr 25 2024, 1:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 4:45 PM
Unknown Object (File)
Feb 21 2025, 6:45 PM
Unknown Object (File)
Jan 28 2025, 8:37 PM
Unknown Object (File)
Jan 28 2025, 8:37 PM
Unknown Object (File)
Jan 28 2025, 8:37 PM
Unknown Object (File)
Jan 28 2025, 8:36 PM
Unknown Object (File)
Jan 23 2025, 4:32 AM
Unknown Object (File)
Jan 23 2025, 4:01 AM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams
Summary

The TagFarcasterChannel screen needs to have context on which community is being tagged. To give TagFarcasterChannel this context we need to introduce TagFarcasterChannelParams which contains a communityID field

Depends on D11784

Test Plan

flow + was able to log out the correct communityID

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 25 2024, 1:40 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 1:40 PM
ginsu edited the summary of this revision. (Show Details)Apr 25 2024, 1:42 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11784: [native] update selectedChannel state to be a FarcasterChannel type.
Harbormaster completed remote builds in B28481: Diff 39511.Apr 25 2024, 1:56 PM
ginsu requested review of this revision.Apr 25 2024, 1:56 PM
ginsu added a child revision: D11793: [native] introduce tag farcaster button.Apr 25 2024, 4:17 PM
inka accepted this revision.Apr 26 2024, 8:32 AM
This revision is now accepted and ready to land.Apr 26 2024, 8:32 AM
ginsu updated this revision to Diff 39668.Apr 29 2024, 11:52 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 29 2024, 11:57 AM
Closed by commit rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams.
Harbormaster completed remote builds in B28588: Diff 39668.Apr 29 2024, 12:17 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
4 lines
components/
5 lines
navigation/
3 lines

Diff 39675

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Show All 22 Lines
import type { import type {
UpdateUserAvatarRequest, UpdateUserAvatarRequest,
UpdateUserAvatarResponse, UpdateUserAvatarResponse,
} from './avatar-types.js'; } from './avatar-types.js';
import type { import type {
CommunityStore, CommunityStore,
AddCommunityPayload, AddCommunityPayload,
CreateOrUpdateFarcasterChannelTagResponse, CreateOrUpdateFarcasterChannelTagResponse,
DeleteFarcasterChannelTagPayload,
} from './community-types.js'; } from './community-types.js';
import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js'; import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js';
import type { import type {
GetVersionActionPayload, GetVersionActionPayload,
LastCommunicatedPlatformDetails, LastCommunicatedPlatformDetails,
} from './device-types.js'; } from './device-types.js';
import type { DraftStore } from './draft-types.js'; import type { DraftStore } from './draft-types.js';
import type { EnabledApps, SupportedApps } from './enabled-apps.js'; import type { EnabledApps, SupportedApps } from './enabled-apps.js';
▲ Show 20 Lines • Show All 1,367 Lines • ▼ Show 20 Lines | {
+payload: CreateOrUpdateFarcasterChannelTagResponse, +payload: CreateOrUpdateFarcasterChannelTagResponse,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED', +type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_SUCCESS',
+payload: DeleteFarcasterChannelTagPayload,
+loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}, },
}>; }>;
export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string); export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string);
export type DispatchSource = 'tunnelbroker' | 'tab-sync'; export type DispatchSource = 'tunnelbroker' | 'tab-sync';
export type SuperAction = { export type SuperAction = {
+type: string, +type: string,
+payload?: ActionPayload, +payload?: ActionPayload,
Show All 15 Lines
View Options

native/components/community-actions-button.react.js

Show All 22 Lines
import type { import type {
UpdateUserAvatarRequest, UpdateUserAvatarRequest,
UpdateUserAvatarResponse, UpdateUserAvatarResponse,
} from './avatar-types.js'; } from './avatar-types.js';
import type { import type {
CommunityStore, CommunityStore,
AddCommunityPayload, AddCommunityPayload,
CreateOrUpdateFarcasterChannelTagResponse, CreateOrUpdateFarcasterChannelTagResponse,
DeleteFarcasterChannelTagPayload,
} from './community-types.js'; } from './community-types.js';
import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js'; import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js';
import type { import type {
GetVersionActionPayload, GetVersionActionPayload,
LastCommunicatedPlatformDetails, LastCommunicatedPlatformDetails,
} from './device-types.js'; } from './device-types.js';
import type { DraftStore } from './draft-types.js'; import type { DraftStore } from './draft-types.js';
import type { EnabledApps, SupportedApps } from './enabled-apps.js'; import type { EnabledApps, SupportedApps } from './enabled-apps.js';
▲ Show 20 Lines • Show All 1,367 Lines • ▼ Show 20 Lines | {
+payload: CreateOrUpdateFarcasterChannelTagResponse, +payload: CreateOrUpdateFarcasterChannelTagResponse,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED', +type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_SUCCESS',
+payload: DeleteFarcasterChannelTagPayload,
+loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}, },
}>; }>;
export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string); export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string);
export type DispatchSource = 'tunnelbroker' | 'tab-sync'; export type DispatchSource = 'tunnelbroker' | 'tab-sync';
export type SuperAction = { export type SuperAction = {
+type: string, +type: string,
+payload?: ActionPayload, +payload?: ActionPayload,
Show All 15 Lines
View Options

native/navigation/route-names.js

Show All 22 Lines
import type { import type {
UpdateUserAvatarRequest, UpdateUserAvatarRequest,
UpdateUserAvatarResponse, UpdateUserAvatarResponse,
} from './avatar-types.js'; } from './avatar-types.js';
import type { import type {
CommunityStore, CommunityStore,
AddCommunityPayload, AddCommunityPayload,
CreateOrUpdateFarcasterChannelTagResponse, CreateOrUpdateFarcasterChannelTagResponse,
DeleteFarcasterChannelTagPayload,
} from './community-types.js'; } from './community-types.js';
import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js'; import type { MessageSourceMetadata, DBOpsStore } from './db-ops-types.js';
import type { import type {
GetVersionActionPayload, GetVersionActionPayload,
LastCommunicatedPlatformDetails, LastCommunicatedPlatformDetails,
} from './device-types.js'; } from './device-types.js';
import type { DraftStore } from './draft-types.js'; import type { DraftStore } from './draft-types.js';
import type { EnabledApps, SupportedApps } from './enabled-apps.js'; import type { EnabledApps, SupportedApps } from './enabled-apps.js';
▲ Show 20 Lines • Show All 1,367 Lines • ▼ Show 20 Lines | {
+payload: CreateOrUpdateFarcasterChannelTagResponse, +payload: CreateOrUpdateFarcasterChannelTagResponse,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED', +type: 'CREATE_OR_UPDATE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_SUCCESS',
+payload: DeleteFarcasterChannelTagPayload,
+loadingInfo: LoadingInfo,
}
| {
+type: 'DELETE_FARCASTER_CHANNEL_TAG_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}, },
}>; }>;
export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string); export type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string);
export type DispatchSource = 'tunnelbroker' | 'tab-sync'; export type DispatchSource = 'tunnelbroker' | 'tab-sync';
export type SuperAction = { export type SuperAction = {
+type: string, +type: string,
+payload?: ActionPayload, +payload?: ActionPayload,
Show All 15 Lines